AC-15105: [CE] PHPUnit 12: Upgrade Payment & Shipping related test cases

Author: shashi011

app/code/Magento/Paypal/Test/Unit/Block/Adminhtml/Order/ViewTest.php

@@ -9,10 +9,12 @@
 
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use Magento\Framework\View\Helper\SecureHtmlRenderer;
 use Magento\Paypal\Block\Adminhtml\Order\View;
 use Magento\Paypal\Model\Adminhtml\Express;
 use Magento\Sales\Model\Order;
 use Magento\Sales\Model\Order\Payment;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -45,6 +47,15 @@ protected function setUp(): void
     {
         $objectManager = new ObjectManager($this);
 
+        $secureRendererMock = $this->createMock(SecureHtmlRenderer::class);
+        $objects = [
+            [
+                SecureHtmlRenderer::class,
+                $secureRendererMock
+            ]
+        ];
+        $objectManager->prepareObjectManager($objects);
+
         $this->order = $this->createPartialMock(
             Order::class,
             ['canUnhold', 'isPaymentReview', 'getState', 'isCanceled', 'getPayment']
@@ -76,8 +87,8 @@ protected function setUp(): void
      * @param string $orderState
      * @param bool $canAuthorize
      * @throws LocalizedException
-     * @dataProvider orderDataProvider
      */
+    #[DataProvider('orderDataProvider')]
     public function testIsOrderAuthorizationAllowed(
         bool $canUnhold,
         bool $isPaymentReview,

app/code/Magento/Paypal/Test/Unit/Block/Adminhtml/Store/SwitcherPluginTest.php

@@ -12,6 +12,7 @@
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
 use Magento\Paypal\Block\Adminhtml\Store\SwitcherPlugin as StoreSwitcherBlockPlugin;
 use Magento\Paypal\Model\Config\StructurePlugin as ConfigStructurePlugin;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -39,11 +40,8 @@ class SwitcherPluginTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->subjectMock = $this->getMockBuilder(StoreSwitcherBlock::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->requestMock = $this->getMockBuilder(RequestInterface::class)
-            ->getMockForAbstractClass();
+        $this->subjectMock = $this->createMock(StoreSwitcherBlock::class);
+        $this->requestMock = $this->createMock(RequestInterface::class);
 
         $this->objectManagerHelper = new ObjectManagerHelper($this);
         $this->plugin = $this->objectManagerHelper->getObject(StoreSwitcherBlockPlugin::class);
@@ -52,9 +50,8 @@ protected function setUp(): void
     /**
      * @param string|null $countryParam
      * @param array $getUrlParams
-     *
-     * @dataProvider beforeGetUrlDataProvider
      */
+    #[DataProvider('beforeGetUrlDataProvider')]
     public function testBeforeGetUrl($countryParam, $getUrlParams)
     {
         $this->requestMock->expects(static::once())

app/code/Magento/Paypal/Test/Unit/Block/Adminhtml/System/Config/Field/CountryTest.php

@@ -8,17 +8,19 @@
 namespace Magento\Paypal\Test\Unit\Block\Adminhtml\System\Config\Field;
 
 use Magento\Backend\Model\Url;
+use Magento\Directory\Helper\Data as DirectoryHelper;
 use Magento\Framework\App\RequestInterface;
 use Magento\Framework\Data\Form\Element\AbstractElement;
+use Magento\Framework\Json\Helper\Data as JsonHelper;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Framework\View\Helper\Js;
 use Magento\Framework\View\Helper\SecureHtmlRenderer;
 use Magento\Paypal\Block\Adminhtml\System\Config\Field\Country;
 use Magento\Paypal\Model\Config\StructurePlugin;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Constraint\StringContains;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
-use Magento\Directory\Helper\Data as DirectoryHelper;
 
 class CountryTest extends TestCase
 {
@@ -58,13 +60,17 @@ class CountryTest extends TestCase
     protected function setUp(): void
     {
         $helper = new ObjectManager($this);
-        $this->_element = $this->getMockForAbstractClass(
+
+        $jsonHelperMock = $this->createMock(JsonHelper::class);
+        $directoryHelperMock = $this->createMock(DirectoryHelper::class);
+        $objects = [
+            [JsonHelper::class, $jsonHelperMock],
+            [DirectoryHelper::class, $directoryHelperMock]
+        ];
+        $helper->prepareObjectManager($objects);
+
+        $this->_element = $this->createPartialMock(
             AbstractElement::class,
-            [],
-            '',
-            false,
-            true,
-            true,
             ['getHtmlId', 'getElementHtml', 'getName']
         );
         $this->_element->expects($this->any())
@@ -76,7 +82,7 @@ protected function setUp(): void
         $this->_element->expects($this->any())
             ->method('getName')
             ->willReturn('name');
-        $this->_request = $this->getMockForAbstractClass(RequestInterface::class);
+        $this->_request = $this->createMock(RequestInterface::class);
         $this->_jsHelper = $this->createMock(Js::class);
         $this->_url = $this->createMock(Url::class);
         $this->helper = $this->createMock(DirectoryHelper::class);
@@ -112,9 +118,9 @@ function (string $style, string $selector): string {
      * @param bool $inherit
      *
      * @return void
-     * @dataProvider renderDataProvider
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
+    #[DataProvider('renderDataProvider')]
     public function testRender(
         ?string $requestCountry,
         ?string $requestDefaultCountry,

app/code/Magento/Paypal/Test/Unit/Block/Adminhtml/System/Config/Field/Enable/AbstractEnableTest.php

@@ -8,17 +8,19 @@
 namespace Magento\Paypal\Test\Unit\Block\Adminhtml\System\Config\Field\Enable;
 
 use Magento\Directory\Helper\Data as DirectoryHelper;
+use Magento\Framework\Data\Form;
+use Magento\Framework\Data\Form\Element\AbstractElement;
 use Magento\Framework\Data\Form\Element\CollectionFactory;
 use Magento\Framework\Escaper;
 use Magento\Framework\Json\Helper\Data as JsonHelper;
 use Magento\Framework\Math\Random;
-use Magento\Framework\Data\Form;
-use Magento\Framework\Data\Form\Element\AbstractElement;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Framework\View\Helper\SecureHtmlRenderer;
-use PHPUnit\Framework\MockObject\MockObject;
 use Magento\Paypal\Test\Unit\Block\Adminhtml\System\Config\Field\Enable\AbstractEnable\Stub;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use ReflectionClass;
 
 /**
  * Class AbstractEnableTest
@@ -27,7 +29,9 @@
  */
 class AbstractEnableTest extends TestCase
 {
-    const EXPECTED_ATTRIBUTE = 'data-enable="stub"';
+    use MockCreationTrait;
+
+    private const EXPECTED_ATTRIBUTE = 'data-enable="stub"';
 
     /**
      * @var Stub
@@ -49,7 +53,7 @@ private function createMocks(array $classes): array
     {
         $mocks = [];
         foreach ($classes as $class) {
-            $mocks[] = $this->getMockBuilder($class)->disableOriginalConstructor()->getMock();
+            $mocks[] = $this->createMock($class);
         }
 
         return $mocks;
@@ -64,8 +68,9 @@ protected function setUp(): void
     {
         $objectManager = new ObjectManager($this);
 
-        $randomMock = $this->getMockBuilder(Random::class)->disableOriginalConstructor()->getMock();
+        $randomMock = $this->createMock(Random::class);
         $randomMock->method('getRandomString')->willReturn('12345abcdef');
+        
         $mockArguments = $this->createMocks([
             \Magento\Framework\Data\Form\Element\Factory::class,
             CollectionFactory::class,
@@ -74,22 +79,21 @@ protected function setUp(): void
         $mockArguments[] = [];
         $mockArguments[] = $this->createMock(SecureHtmlRenderer::class);
         $mockArguments[] = $randomMock;
-        $this->elementMock = $this->getMockBuilder(AbstractElement::class)
-            ->addMethods(['getTooltip'])
-            ->onlyMethods(
-                [
-                    'getHtmlId',
-                    'getForm'
-                ]
-            )->setConstructorArgs($mockArguments)
-            ->getMockForAbstractClass();
+        
+        $this->elementMock = $this->createPartialMockWithReflection(
+            AbstractElement::class,
+            ['getHtmlId', 'getForm', 'getTooltip']
+        );
 
-        $objectManager = new ObjectManager($this);
         $escaper = $objectManager->getObject(Escaper::class);
-        $reflection = new \ReflectionClass($this->elementMock);
-        $reflection_property = $reflection->getProperty('_escaper');
-        $reflection_property->setAccessible(true);
-        $reflection_property->setValue($this->elementMock, $escaper);
+        $reflection = new ReflectionClass(AbstractElement::class);
+        $reflectionProperty = $reflection->getProperty('_escaper');
+        $reflectionProperty->setAccessible(true);
+        $reflectionProperty->setValue($this->elementMock, $escaper);
+        
+        $randomProperty = $reflection->getProperty('random');
+        $randomProperty->setAccessible(true);
+        $randomProperty->setValue($this->elementMock, $randomMock);
 
         $objects = [
             [
@@ -135,11 +139,8 @@ public function testGetUiId()
      */
     public function testRender()
     {
-        $formMock = $this->getMockBuilder(Form::class)
-            ->addMethods(['getFieldNameSuffix'])
-            ->disableOriginalConstructor()
-            ->getMock();
-
+        $formMock = $this->createPartialMockWithReflection(Form::class, ['getFieldNameSuffix']);
+    
         $this->elementMock->expects($this->any())
             ->method('getHtmlId')
             ->willReturn('test-html-id');
@@ -149,7 +150,6 @@ public function testRender()
         $this->elementMock->expects($this->any())
             ->method('getForm')
             ->willReturn($formMock);
-
         $formMock->expects($this->any())
             ->method('getFieldNameSuffix')
             ->willReturn('');

app/code/Magento/Paypal/Test/Unit/Block/Adminhtml/System/Config/Fieldset/GroupTest.php

@@ -11,10 +11,11 @@
 use Magento\Config\Model\Config\Structure\Element\Group;
 use Magento\Framework\Data\Form\Element\AbstractElement;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use Magento\Framework\View\Helper\SecureHtmlRenderer;
 use Magento\User\Model\User;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
-use Magento\Framework\View\Helper\SecureHtmlRenderer;
 
 class GroupTest extends TestCase
 {
@@ -50,13 +51,8 @@ protected function setUp(): void
     {
         $helper = new ObjectManager($this);
         $this->_group = $this->createMock(Group::class);
-        $this->_element = $this->getMockForAbstractClass(
+        $this->_element = $this->createPartialMock(
             AbstractElement::class,
-            [],
-            '',
-            false,
-            true,
-            true,
             ['getHtmlId', 'getElementHtml', 'getName', 'getElements', 'getId']
         );
         $this->_element->expects($this->any())
@@ -94,18 +90,22 @@ function (string $style, string $selector): string {
                 }
             );
 
+        $helper->prepareObjectManager([
+            [SecureHtmlRenderer::class, $secureRendererMock]
+        ]);
+
         $this->_model = $helper->getObject(
             \Magento\Paypal\Block\Adminhtml\System\Config\Fieldset\Group::class,
-            ['authSession' => $this->_authSession, 'secureRenderer' => $secureRendererMock]
+            ['authSession' => $this->_authSession]
         );
         $this->_model->setGroup($this->_group);
     }
 
     /**
      * @param mixed $expanded
      * @param int $expected
-     * @dataProvider isCollapseStateDataProvider
      */
+    #[DataProvider('isCollapseStateDataProvider')]
     public function testIsCollapseState($expanded, $expected)
     {
         $this->_user->setExtra(['configState' => []]);

app/code/Magento/Paypal/Test/Unit/Block/Adminhtml/System/Config/Fieldset/HintTest.php

@@ -8,13 +8,16 @@
 namespace Magento\Paypal\Test\Unit\Block\Adminhtml\System\Config\Fieldset;
 
 use Magento\Framework\Data\Form\Element\AbstractElement;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Paypal\Block\Adminhtml\System\Config\Fieldset\Hint;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class HintTest extends TestCase
 {
+    use MockCreationTrait;
+
     /**
      * @var Hint
      */
@@ -27,15 +30,14 @@ class HintTest extends TestCase
 
     protected function setUp(): void
     {
-        $om = new ObjectManager($this);
+        $objectManager = new ObjectManager($this);
 
-        $this->element = $this->getMockBuilder(AbstractElement::class)
-            ->addMethods(['getComment'])
-            ->onlyMethods(['getHtmlId'])
-            ->disableOriginalConstructor()
-            ->getMockForAbstractClass();
+        $this->element = $this->createPartialMockWithReflection(
+            AbstractElement::class,
+            ['getComment', 'getHtmlId']
+        );
 
-        $this->block = $om->getObject(Hint::class);
+        $this->block = $objectManager->getObject(Hint::class);
     }
 
     /**

app/code/Magento/Paypal/Test/Unit/Block/Adminhtml/System/Config/Fieldset/PaymentTest.php

@@ -12,6 +12,7 @@
 use Magento\Framework\Data\Form\Element\AbstractElement;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Paypal\Block\Adminhtml\System\Config\Fieldset\Payment;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -20,8 +21,8 @@ class PaymentTest extends TestCase
     /**#@+
      * Activity config path
      */
-    const CONFIG_PATH_ACTIVE = 'payment/path/active';
-    const CONFIG_PATH_NOT_ACTIVE = 'payment/path/not-active';
+    private const CONFIG_PATH_ACTIVE = 'payment/path/active';
+    private const CONFIG_PATH_NOT_ACTIVE = 'payment/path/not-active';
     /**#@-*/
 
     /**
@@ -48,13 +49,8 @@ protected function setUp(): void
     {
         $helper = new ObjectManager($this);
         $this->_group = $this->createMock(Group::class);
-        $this->_element = $this->getMockForAbstractClass(
+        $this->_element = $this->createPartialMock(
             AbstractElement::class,
-            [],
-            '',
-            false,
-            true,
-            true,
             ['getHtmlId', 'getElementHtml', 'getName', 'getElements', 'getId']
         );
         $this->_element->expects($this->any())
@@ -80,9 +76,7 @@ protected function setUp(): void
         $this->_model->setGroup($this->_group);
     }
 
-    /**
-     * @dataProvider isPaymentEnabledDataProvider
-     */
+    #[DataProvider('isPaymentEnabledDataProvider')]
     public function testIsPaymentEnabled($groupConfig, $expected)
     {
         $this->_element->setGroup($groupConfig);