Fixed static checks issues

Author: bohdan-harniuk

src/com/magento/idea/magento2plugin/actions/generation/PluginGenerateMethodHandlerBase.java

@@ -72,7 +72,7 @@ public abstract class PluginGenerateMethodHandlerBase implements LanguageCodeIns
      */
     public PluginGenerateMethodHandlerBase(final Plugin.PluginType type) {
         this.type = type.toString();
-        this.fillTextBuffer = FillTextBufferWithPluginMethods.getInstance();
+        this.fillTextBuffer = new FillTextBufferWithPluginMethods();
         this.collectInsertedMethods = CollectInsertedMethods.getInstance();
         this.validatorBundle = new ValidatorBundle();
         this.commonBundle = new CommonBundle();

src/com/magento/idea/magento2plugin/actions/generation/generator/PluginClassGenerator.java

@@ -73,7 +73,7 @@ public PluginClassGenerator(
         this.directoryGenerator = DirectoryGenerator.getInstance();
         this.fileFromTemplateGenerator = new FileFromTemplateGenerator(project);
         this.getFirstClassOfFile = GetFirstClassOfFile.getInstance();
-        this.fillTextBuffer = FillTextBufferWithPluginMethods.getInstance();
+        this.fillTextBuffer = new FillTextBufferWithPluginMethods();
         this.collectInsertedMethods = CollectInsertedMethods.getInstance();
         this.pluginFileData = pluginFileData;
         this.project = project;

src/com/magento/idea/magento2plugin/actions/generation/util/FillTextBufferWithPluginMethods.java

@@ -20,19 +20,6 @@
 import org.jetbrains.annotations.NotNull;
 
 public class FillTextBufferWithPluginMethods {
-    private static FillTextBufferWithPluginMethods INSTANCE = null;
-
-    /**
-     * Get util instance.
-     *
-     * @return FillTextBufferWithPluginMethods
-     */
-    public static FillTextBufferWithPluginMethods getInstance() {
-        if (null == INSTANCE) {
-            INSTANCE = new FillTextBufferWithPluginMethods();
-        }
-        return INSTANCE;
-    }
 
     /**
      * Fill text buffer with plugin methods.
@@ -43,27 +30,30 @@ public static FillTextBufferWithPluginMethods getInstance() {
      * @param textBuf StringBuffer
      * @param pluginMethods PluginMethodData
      */
+    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
     public void execute(
             final @NotNull Key<Object> targetClassKey,
             final Set<CharSequence> insertedMethodsNames,
             final @NotNull PhpClassReferenceResolver resolver,
             final @NotNull StringBuffer textBuf,
-            final @NotNull PluginMethodData[] pluginMethods
+            final @NotNull PluginMethodData... pluginMethods
     ) {
-        for (PluginMethodData pluginMethod : pluginMethods) {
+        for (final PluginMethodData pluginMethod : pluginMethods) {
             insertedMethodsNames.add(pluginMethod.getMethod().getName());
-            PhpDocComment comment = pluginMethod.getDocComment();
+            final PhpDocComment comment = pluginMethod.getDocComment();
+
             if (comment != null) {
                 textBuf.append(comment.getText());
             }
-            Method targetMethod = pluginMethod.getTargetMethod();
-            Parameter[] parameters = targetMethod.getParameters();
-            Collection<PsiElement> processElements = new ArrayList<>(Arrays.asList(parameters));
+            final Method targetMethod = pluginMethod.getTargetMethod();
+            final Parameter[] parameters = targetMethod.getParameters();
+            final Collection<PsiElement> processElements =
+                    new ArrayList<>(Arrays.asList(parameters));
             resolver.processElements(processElements);
-            PsiElement targetClass = (PsiElement) pluginMethod.getTargetMethod()
+            final PsiElement targetClass = (PsiElement) pluginMethod.getTargetMethod()
                     .getUserData(targetClassKey);
             resolver.processElement(targetClass);
-            PhpReturnType returnType = targetMethod.getReturnType();
+            final PhpReturnType returnType = targetMethod.getReturnType();
             if (returnType != null) {
                 resolver.processElement(returnType);
             }