MQE-1024: Refactor Algorithm For Mftf Build Groups

- fix review comments

Author: imeron2433

src/Magento/FunctionalTestingFramework/Test/Objects/TestObject.php

@@ -15,11 +15,13 @@
  */
 class TestObject
 {
+    const WAIT_TIME_ATTRIBUTE = 'time';
+
     const TEST_ACTION_WEIGHT = [
         'waitForPageLoad' => 1500,
         'amOnPage' => 1000,
         'waitForLoadingMaskToDisappear' => 500,
-        'wait' => 'time',
+        'wait' => self::WAIT_TIME_ATTRIBUTE,
         'comment' => 5,
         'assertCount' => 5,
         'closeAdminNotification' => 10
@@ -208,7 +210,7 @@ private function calculateWeightedActionTimes($actions)
             /** @var ActionObject $action */
             if (array_key_exists($action->getType(), self::TEST_ACTION_WEIGHT)) {
                 $weight = self::TEST_ACTION_WEIGHT[$action->getType()];
-                if (is_string($weight) && $weight === 'time') {
+                if ($weight === self::WAIT_TIME_ATTRIBUTE) {
                     $weight = intval($action->getCustomActionAttributes()[$weight]) * 1000;
                 }
 

src/Magento/FunctionalTestingFramework/Util/Sorter/ParallelGroupSorter.php

@@ -237,24 +237,24 @@ private function getSuiteToSize($suiteNamesToTests)
     private function splitTestSuite($suiteName, $tests, $maxTime)
     {
         arsort($tests);
-        $split_suites = [];
+        $splitSuites = [];
         $availableTests = $tests;
-        $split_count = 0;
+        $splitCount = 0;
 
         foreach ($tests as $test => $size) {
             if (!array_key_exists($test, $availableTests)) {
                 continue;
             }
 
             $group = $this->createTestGroup($maxTime, $test, $size, $availableTests);
-            $split_suites["{$suiteName}_${split_count}"] = $group;
-            $this->addSuiteToConfig($suiteName, "{$suiteName}_${split_count}", $group);
+            $splitSuites["{$suiteName}_${splitCount}"] = $group;
+            $this->addSuiteToConfig($suiteName, "{$suiteName}_${splitCount}", $group);
 
             $availableTests = array_diff_key($availableTests, $group);
-            $split_count++;
+            $splitCount++;
         }
 
-        return $split_suites;
+        return $splitSuites;
     }
 
     /**