File tree Expand file tree Collapse file tree 1 file changed +3
-1
lines changed
src/Magento/FunctionalTestingFramework/Suite/Util Expand file tree Collapse file tree 1 file changed +3
-1
lines changed Original file line number Diff line number Diff line change @@ -65,7 +65,7 @@ public function parseSuiteDataIntoObjects($parsedSuiteData)
6565 // skip non array items parsed from suite (suite objects will always be arrays)
6666 continue ;
6767 }
68- //check for collisions between suite and existing group names
68+
6969 $ this ->validateSuiteName ($ parsedSuite );
7070
7171 //extract include and exclude references
@@ -115,12 +115,14 @@ public function parseSuiteDataIntoObjects($parsedSuiteData)
115115 */
116116 private function validateSuiteName ($ parsedSuite )
117117 {
118+ //check if name used is using special char or the "default" reserved name
118119 NameValidationUtil::validateName ($ parsedSuite [self ::NAME ], 'Suite ' );
119120 if ($ parsedSuite [self ::NAME ] == 'default ' ) {
120121 throw new XmlException ("A Suite can not have the name \"default \"" );
121122 }
122123
123124 $ suiteName = $ parsedSuite [self ::NAME ];
125+ //check for collisions between suite and existing group names
124126 $ testGroupConflicts = TestObjectHandler::getInstance ()->getTestsByGroup ($ suiteName );
125127 if (!empty ($ testGroupConflicts )) {
126128 $ testGroupConflictsFileNames = "" ;
You can’t perform that action at this time.
0 commit comments