MQE-1181: Fatal error while test running

- Moved reset session to after all test runs
- changed suites to not run suite_after if last test was a failure (compatibility issues)

Author: KevinBKozan

src/Magento/FunctionalTestingFramework/Extension/TestContextExtension.php

@@ -17,6 +17,9 @@
 class TestContextExtension extends \Codeception\Extension
 {
     const TEST_PHASE_AFTER = "_after";
+    // @codingStandardsIgnoreStart
+    const MAGENTO_WEB_DRIVER_CLASS = "\Magento\FunctionalTestingFramework\Module\MagentoWebDriver";
+    // @codingStandardsIgnoreEnd
 
     /**
      * Codeception Events Mapping to methods
@@ -43,7 +46,7 @@ public function testFail(\Codeception\Event\FailEvent $e)
             $this->runAfterBlock($e, $cest);
         }
     }
-
+    
     /**
      * Codeception event listener function, triggered on test error.
      * @param \Codeception\Event\TestEvent $e
@@ -62,14 +65,21 @@ function () use ($cest) {
         ));
         $errors = $testResultObject->errors();
         if (!empty($errors)) {
-            $stack = $errors[0]->thrownException()->getTrace();
-            $context = $this->extractContext($stack, $cest->getTestMethod());
-            // Do not attempt to run _after if failure was in the _after block
-            // Try to run _after but catch exceptions to prevent them from overwriting original failure.
-            if ($context != TestContextExtension::TEST_PHASE_AFTER) {
-                $this->runAfterBlock($e, $cest);
+            foreach ($errors as $error) {
+                if ($error->failedTest()->getTestMethod() == $cest->getName()) {
+                    $stack = $errors[0]->thrownException()->getTrace();
+                    $context = $this->extractContext($stack, $cest->getTestMethod());
+                    // Do not attempt to run _after if failure was in the _after block
+                    // Try to run _after but catch exceptions to prevent them from overwriting original failure.
+                    if ($context != TestContextExtension::TEST_PHASE_AFTER) {
+                        $this->runAfterBlock($e, $cest);
+                    }
+                    continue;
+                }
             }
         }
+        // Reset Session and Cookies after all Test Runs, workaround due to functional.suite.yml restart: true
+        $this->getModule(self::MAGENTO_WEB_DRIVER_CLASS)->_runAfter($e->getTest());
     }
 
     /**
@@ -90,8 +100,6 @@ function () use ($cest, $I) {
                 null,
                 $cest
             ));
-            // Reset Session and Cookies, workaround due to functional.suite.yml restart: true
-            $this->getModule(MagentoWebDriver::class)->_runAfter($e->getTest());
         } catch (\Exception $e) {
             // Do not rethrow Exception
         }

src/Magento/FunctionalTestingFramework/Suite/views/SuiteClass.mustache

@@ -59,16 +59,38 @@ class {{suiteName}} extends \Codeception\GroupObject
     {{#after}}
     public function _after(\Codeception\Event\TestEvent $e)
     {
-        $this->executePostConditions();
+        $this->executePostConditions($e);
     }
 
 
-    private function executePostConditions()
+    private function executePostConditions(\Codeception\Event\TestEvent $e)
     {
         if ($this->currentTestRun == $this->testCount) {
             print sprintf(self::$HOOK_EXECUTION_INIT, "after");
 
             try {
+                // Find out if Test in Suite failed, will cause potential failures in suite after
+                $cest = $e->getTest();
+
+                //Access private TestResultObject to find stack and if there are any errors (as opposed to failures)
+                $testResultObject = call_user_func(\Closure::bind(
+                    function () use ($cest) {
+                        return $cest->getTestResultObject();
+                    },
+                    $cest
+                ));
+                $errors = $testResultObject->errors();
+
+                if (!empty($errors)) {
+                    foreach ($errors as $error) {
+                        if ($error->failedTest()->getTestMethod() == $cest->getName()) {
+                            // Do not attempt to run _after if failure was in the _after block
+                            // Try to run _after but catch exceptions to prevent them from overwriting original failure.
+                            \PHPUnit_Framework_Assert::fail("LAST TESTS FAILED IN SUITE, SUITE_AFTER CANNOT BE RUN");
+                        }
+                    }
+                }
+
                 {{> testActions}}
             } catch (\Exception $exception) {
                 print $exception->getMessage();