MQE-1541: Add option to generate:tests for XSD validation on 'merged files'

Author: soumyau

src/Magento/FunctionalTestingFramework/Config/Reader/Filesystem.php

@@ -232,13 +232,13 @@ protected function validateSchema($configMerger, $filename = null)
             $errors = [];
             if ($configMerger && !$configMerger->validate($this->schemaFile, $errors)) {
                 foreach ($errors as $error) {
-                    $error = str_replace("\n", "", $error);
+                    $error = str_replace(PHP_EOL, "", $error);
                     LoggingUtil::getInstance()->getLogger(Filesystem::class)->criticalFailure(
-                        "Schema validation error. ",
+                        "Schema validation error:",
                         ($filename ? [ "file"=> $filename, "error" => $error]: ["error" => $error])
                     );
                 }
-                throw new \Exception("Error: schema validation errors found in xml file(s) " . $filename . "\n");
+                throw new \Exception("Schema validation errors found in xml file(s).");
             }
         }
     }

src/Magento/FunctionalTestingFramework/Util/Logger/MftfLogger.php

@@ -34,14 +34,15 @@ public function deprecation($message, array $context = [])
      *
      * @param  string $message The log message.
      * @param  array  $context The log context.
+     * @param  string  $filename
      * @return void
      */
-    public function criticalFailure($message, array $context = [])
+    public function criticalFailure($message, array $context = [], $filename = null)
     {
-        $message = "CRITICAL FAILURE: " . $message;
+        $message = "FAILURE: " . $message . $filename;
         // Suppress print during unit testing
         if (MftfApplicationConfig::getConfig()->getPhase() !== MftfApplicationConfig::UNIT_TEST_PHASE) {
-            print ($message . json_encode($context) . "\n");
+            print ($message . implode( "\n", $context) . "\n");
         }
         parent::critical($message, $context);
     }