MQE-1031: Empty files are flagged during generation or dealt with

gracefully

- Added windows compatibility for checks
- Fixed static check in Filesystem

Author: aljcalandra

.gitignore

@@ -13,4 +13,5 @@ coverage/
 .vscode
 codeception.yml
 dev/tests/functional/MFTF.suite.yml
-dev/tests/functional/_output
+dev/tests/functional/_output
+dev/tests/mftf.log

bin/all-checks.bat

@@ -0,0 +1,8 @@
+:: Copyright © Magento, Inc. All rights reserved.
+:: See COPYING.txt for license details.
+
+@echo off
+call bin\static-checks.bat
+
+@echo off
+call bin\phpunit-checks.bat

bin/copyright-check.bat

@@ -0,0 +1,41 @@
+:: Copyright © Magento, Inc. All rights reserved.
+:: See COPYING.txt for license details.
+
+@echo off
+SETLOCAL EnableDelayedExpansion
+SET BLACKLIST_FILE=bin/blacklist.txt
+SET i=0
+
+FOR /F %%x IN ('git ls-tree --full-tree -r --name-only HEAD') DO (
+    SET GOOD_EXT=
+    if "%%~xx"==".php" set GOOD_EXT=1
+    if "%%~xx"==".xml" set GOOD_EXT=1
+    if "%%~xx"==".xsd" set GOOD_EXT=1
+    IF DEFINED GOOD_EXT (
+        SET BLACKLISTED=
+        FOR /F "tokens=* skip=5" %%f IN (%BLACKLIST_FILE%) DO (
+            SET LINE=%%x
+            IF NOT "!LINE!"=="!LINE:%%f=!" (
+                SET BLACKLISTED=1
+            )
+        )
+        IF NOT DEFINED BLACKLISTED (
+            FIND "Copyright © Magento, Inc. All rights reserved." %%x >nul
+            IF ERRORLEVEL 1 (
+                SET /A i+=1
+                SET NO_COPYRIGHT_LIST[!i!]=%%x
+            )
+        )
+    )
+)
+
+IF DEFINED NO_COPYRIGHT_LIST[1] (
+    ECHO THE FOLLOWING FILES ARE MISSING THE MAGENTO COPYRIGHT:
+    ECHO.
+    ECHO     Copyright © Magento, Inc. All rights reserved.
+    ECHO     See COPYING.txt for license details.
+    ECHO.
+    FOR /L %%a IN (1,1,%i%) DO (
+        ECHO !NO_COPYRIGHT_LIST[%%a]!
+    )
+)

bin/static-checks.bat

@@ -5,17 +5,15 @@
 
 @echo off
 @echo ===============================PHP CODE SNIFFER REPORT===============================
-call vendor\bin\phpcs .\src --standard=.\dev\tests\static\Magento --ignore=src\Magento\FunctionalTestingFramework\Group,src\Magento\FunctionalTestingFramework\AcceptanceTester.php
-call vendor\bin\phpcs .\dev\tests\unit --standard=.\dev\tests\static\Magento
-call vendor\bin\phpcs .\dev\tests\verification --standard=.\dev\tests\static\Magento --ignore=dev\tests\verification\_generated
+call vendor\bin\phpcs --standard=.\dev\tests\static\Magento --ignore=src/Magento/FunctionalTestingFramework/Group,src/Magento/FunctionalTestingFramework/AcceptanceTester.php .\src
+call vendor\bin\phpcs --standard=.\dev\tests\static\Magento .\dev\tests\unit
+call vendor\bin\phpcs --standard=.\dev\tests\static\Magento --ignore=dev/tests/verification/_generated .\dev\tests\verification
 
 @echo ===============================COPY PASTE DETECTOR REPORT===============================
 call vendor\bin\phpcpd .\src
 
-@echo "===============================PHP MESS DETECTOR REPORT===============================
-vendor\bin\phpmd .\src text \dev\tests\static\Magento\CodeMessDetector\ruleset.xml --exclude _generated,src\Magento\FunctionalTestingFramework\Group,src\Magento\FunctionalTestingFramework\AcceptanceTester.php
+@echo ===============================PHP MESS DETECTOR REPORT===============================
+call vendor\bin\phpmd --exclude _generated,src\Magento\FunctionalTestingFramework\Group,src\Magento\FunctionalTestingFramework\AcceptanceTester.php .\src text \dev\tests\static\Magento\CodeMessDetector\ruleset.xml
 
 @echo ===============================MAGENTO COPYRIGHT REPORT===============================
-echo msgbox "INFO:Copyright check currently not run as part of .bat implementation" > "%temp%\popup.vbs"
-wscript.exe "%temp%\popup.vbs"
-::bin\copyright-check
+call bin\copyright-check.bat

src/Magento/FunctionalTestingFramework/Config/Reader/Filesystem.php

@@ -4,6 +4,7 @@
  * See COPYING.txt for license details.
  */
 namespace Magento\FunctionalTestingFramework\Config\Reader;
+
 use Magento\FunctionalTestingFramework\Config\MftfApplicationConfig;
 use Magento\FunctionalTestingFramework\Util\Logger\LoggingUtil;
 
@@ -211,7 +212,8 @@ protected function verifyFileStatus($content, $fileName)
         if (empty($content)) {
             if (MftfApplicationConfig::getConfig()->verboseEnabled()) {
                 LoggingUtil::getInstance()->getLogger(Filesystem::class)->warn(
-                    "XML File is empty.", ["File" => $fileName]
+                    "XML File is empty.",
+                    ["File" => $fileName]
                 );
             }
             return false;