fix pr feedback

Author: mikedebock

internal/config/schemas/schema-1.yaml

@@ -112,10 +112,11 @@ definitions:
                 type: string
                 enum:
                   - aws
-                  - gcp
                   - azure
-                  - terraform_cloud
+                  - gcp
+                  - http
                   - local
+                  - terraform_cloud
           - $ref: "#/definitions/RemoteState"
 
   RemoteState:

internal/state/http.go

@@ -7,17 +7,17 @@ import (
 // HttpState HTTP backend configuration.
 type HttpState struct {
 	Address                string `mapstructure:"address"`
-	UpdateMethod           string `mapstructure:"update_method" default:"POST"`
+	UpdateMethod           string `mapstructure:"update_method"`
 	LockAddress            string `mapstructure:"lock_address"`
-	LockMethod             string `mapstructure:"lock_method" default:"LOCK"`
+	LockMethod             string `mapstructure:"lock_method"`
 	UnlockAddress          string `mapstructure:"unlock_address"`
-	UnlockMethod           string `mapstructure:"unlock_method" default:"UNLOCK"`
+	UnlockMethod           string `mapstructure:"unlock_method"`
 	Username               string `mapstructure:"username"`
 	Password               string `mapstructure:"password"`
 	SkipCertVerification   bool   `mapstructure:"skip_cert_verification" default:"false"`
-	RetryMax               int    `mapstructure:"retry_max" default:"2"`
-	RetryWaitMin           int    `mapstructure:"retry_wait_min" default:"1"`
-	RetryWaitMax           int    `mapstructure:"retry_wait_max" default:"30"`
+	RetryMax               int    `mapstructure:"retry_max"`
+	RetryWaitMin           int    `mapstructure:"retry_wait_min"`
+	RetryWaitMax           int    `mapstructure:"retry_wait_max"`
 	ClientCertificatePEM   string `mapstructure:"client_certificate_pem"`
 	ClientPrivateKeyPEM    string `mapstructure:"client_private_key_pem"`
 	ClientCACertificatePEM string `mapstructure:"client_ca_certificate_pem"`
@@ -110,22 +110,8 @@ func (hr *HttpRenderer) RemoteState() (string, error) {
 
 		config = {
 			address               = "{{ .State.Address }}"
+			{{- if .State.UpdateMethod }}
 			update_method         = "{{ .State.UpdateMethod }}"
-			{{- if .State.Username }}
-			username              = "{{ .State.Username }}"
-			{{- end }}
-			{{- if .State.Password }}
-			password              = "{{ .State.Password }}"
-			{{- end }}
-			skip_cert_verification = {{ .State.SkipCertVerification }}
-			{{- if gt .State.RetryMax 0 }}
-			retry_max             = {{ .State.RetryMax }}
-			{{- end }}
-			{{- if gt .State.RetryWaitMin 0 }}
-			retry_wait_min        = {{ .State.RetryWaitMin }}
-			{{- end }}
-			{{- if gt .State.RetryWaitMax 0 }}
-			retry_wait_max        = {{ .State.RetryWaitMax }}
 			{{- end }}
 		}
 	}

internal/state/http_test.go

@@ -5,6 +5,25 @@ import (
 	"testing"
 )
 
+func TestHttpRendererBackendMinimal(t *testing.T) {
+	r := HttpRenderer{
+		state: &HttpState{
+			Address: "https://example.com/state",
+		},
+		BaseRenderer: BaseRenderer{
+			identifier: "test-1/component-1",
+		},
+	}
+
+	b, err := r.Backend()
+	assert.NoError(t, err)
+	assert.Equal(t, `
+	backend "http" {
+		address               = "https://example.com/state"
+	}
+	`, b)
+}
+
 func TestHttpRendererBackend(t *testing.T) {
 	r := HttpRenderer{
 		state: &HttpState{
@@ -61,11 +80,7 @@ EOT
 func TestHttpRendererRemoteState(t *testing.T) {
 	r := HttpRenderer{
 		state: &HttpState{
-			Address:              "https://example.com/state",
-			UpdateMethod:         "POST",
-			Username:             "user",
-			Password:             "pass",
-			SkipCertVerification: false,
+			Address: "https://example.com/state",
 		},
 		BaseRenderer: BaseRenderer{
 			identifier: "test-1/component-1",
@@ -81,10 +96,6 @@ func TestHttpRendererRemoteState(t *testing.T) {
 
 		config = {
 			address               = "https://example.com/state"
-			update_method         = "POST"
-			username              = "user"
-			password              = "pass"
-			skip_cert_verification = false
 		}
 	}
 	`, rs)

internal/state/schemas/http.schema.json

@@ -6,6 +6,9 @@
     "address"
   ],
   "properties": {
+    "plugin": {
+      "type": "string"
+    },
     "address": {
       "type": "string",
       "description": "The address of the REST endpoint."