Fixed coordinates problems in chapter 10

Author: lwjglgamedev

README.md

@@ -6,6 +6,8 @@ This [online book](bookcontents/) will introduce the main concepts required to w
 
 We will use [LWJGL](http://www.lwjgl.org/) as the Java library which provides the required bindings to use Vulkan and any other required APIs. This book is the result of my self learning language, that I think it may help the community.
 
+![Sample screen shot](screen-shot.png)
+
 ## Book Code
 
 The book itself is also hosted in [GitHub](https://github.com/lwjglgamedev/vulkanbook/tree/master/bookcontents).

bookcontents/README.md

@@ -12,4 +12,4 @@ The book is structured in the following chapters:
 - [Chapter 07](chapter-07/chapter-07.md): In this chapter we go 3D by implementing depth testing and add windows resizing support.
 - [Chapter 08](chapter-08/chapter-08.md): In this chapter we add support for loading complex 3D models using Assimp and textures.
 - [Chapter 09](chapter-09/chapter-09.md): We will automatically generate mipmaps, add support for transparent objects, add a camera to move around the scene and use dynamic uniform objects.
-- [Chapter 10](chapter-09/chapter-10.md): Deferred rendering (Draft code, still missing PBR lighting).
+- [Chapter 10](chapter-09/chapter-10.md): Deferred rendering (Draft code, synchronization needs to be reviewed).

booksamples/chapter-10/resources/shaders/lighting_fragment.glsl

@@ -1,5 +1,4 @@
 #version 450
-precision highp float;
 
 const int MAX_LIGHTS = 10;
 const float PI = 3.14159265359;
@@ -128,7 +127,7 @@ void main() {
     float metallic = pbrSampledValue.b;
 
     // Retrieve position from depth
-    vec4 clip    = vec4(inTextCoord * 2.0 - 1.0, texture(depthSampler, inTextCoord).x, 1.0);
+    vec4 clip    = vec4(inTextCoord.x * 2.0 - 1.0, inTextCoord.y * -2.0 + 1.0, texture(depthSampler, inTextCoord).x, 1.0);
     vec4 world_w = projUniform.invProjectionMatrix * clip;
     vec3 pos     = world_w.xyz / world_w.w;
 

booksamples/chapter-10/resources/shaders/lighting_fragment.glsl.spv

@@ -1,10 +1,9 @@
 #version 450
-precision highp float;
 
 layout(location = 0) out vec2 outTextCoord;
 
 void main()
 {
     outTextCoord = vec2((gl_VertexIndex << 1) & 2, gl_VertexIndex & 2);
-    gl_Position = vec4(outTextCoord * 2.0f - 1.0f, 0.0f, 1.0f);
+    gl_Position = vec4(outTextCoord.x * 2.0f - 1.0f, outTextCoord.y * -2.0f + 1.0f, 0.0f, 1.0f);
 }

booksamples/chapter-10/resources/shaders/lighting_vertex.glsl

@@ -169,7 +169,7 @@ public void preRecordCommandBuffer(int idx) {
 
             commandBuffer.reset();
             VkClearValue.Buffer clearValues = VkClearValue.callocStack(1, stack);
-            clearValues.apply(0, v -> v.color().float32(0, 0.5f).float32(1, 0.7f).float32(2, 0.9f).float32(3, 1));
+            clearValues.apply(0, v -> v.color().float32(0, 0.0f).float32(1, 0.0f).float32(2, 0.0f).float32(3, 1));
 
             VkRect2D renderArea = VkRect2D.callocStack(stack);
             renderArea.offset().set(0, 0);
@@ -191,8 +191,8 @@ public void preRecordCommandBuffer(int idx) {
 
             VkViewport.Buffer viewport = VkViewport.callocStack(1, stack)
                     .x(0)
-                    .y(0)
-                    .height(height)
+                    .y(height)
+                    .height(-height)
                     .width(width)
                     .minDepth(0.0f)
                     .maxDepth(1.0f);

booksamples/chapter-10/resources/shaders/lighting_vertex.glsl.spv

@@ -55,7 +55,7 @@ public VertexBufferStructure() {
         viAttrs.get(i)
                 .binding(0)
                 .location(i)
-                .format(VK_FORMAT_R32G32B32_SFLOAT)
+                .format(VK_FORMAT_R32G32_SFLOAT)
                 .offset(NORMAL_COMPONENTS * GraphConstants.FLOAT_LENGTH * 3 + POSITION_COMPONENTS * GraphConstants.FLOAT_LENGTH);
 
         viBindings.get(0)