Skip to content

Commit eb2ce45

Browse files
committed
release the final fix for issue with text conditionining on first few tokens
1 parent 08b914d commit eb2ce45

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ Please join <a href="https://discord.gg/xBPBXfcFHd"><img alt="Join us on Discord
2424

2525
- <a href="https://github.com/MarcusLoppe">Marcus</a> yet again for running the experiments to validate that it is possible to extend the system from triangles to <a href="https://github.com/lucidrains/meshgpt-pytorch/issues/54#issuecomment-1906789076">quads</a>
2626

27+
- <a href="https://github.com/MarcusLoppe">Marcus</a> for identifying <a href="https://github.com/lucidrains/meshgpt-pytorch/issues/80">an issue</a> with text conditioning and for running all the experiments that led to it being resolved
28+
2729
## Install
2830

2931
```bash

meshgpt_pytorch/meshgpt_pytorch.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1038,7 +1038,7 @@ def __init__(
10381038
fine_attn_dim_head = 32,
10391039
fine_attn_heads = 8,
10401040
pad_id = -1,
1041-
num_sos_tokens = 1,
1041+
num_sos_tokens = None,
10421042
condition_on_text = False,
10431043
text_condition_model_types = ('t5',),
10441044
text_condition_cond_drop_prob = 0.25,
@@ -1062,6 +1062,7 @@ def __init__(
10621062
# the fine transformer sos token
10631063
# as well as a projection of pooled text embeddings to condition it
10641064

1065+
num_sos_tokens = default(num_sos_tokens, 1 if not condition_on_text else 4)
10651066
assert num_sos_tokens > 0
10661067

10671068
self.num_sos_tokens = num_sos_tokens

meshgpt_pytorch/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '1.2.6'
1+
__version__ = '1.2.7'

0 commit comments

Comments
 (0)