-
-
Notifications
You must be signed in to change notification settings - Fork 313
swag_ondemand mod: Use swag_url label to construct default container urls, if available #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: swag-ondemand
Are you sure you want to change the base?
swag_ondemand mod: Use swag_url label to construct default container urls, if available #1088
Conversation
|
PR build pushed to |
You can test it by using this tag ^ in the |
|
PR build pushed to |
d7613a8 to
2b00859
Compare
|
PR build pushed to |
|
PR build pushed to |
|
PR build pushed to |
Ah-ha! Very slick, thanks! I've tested it now, and added some logging to make it clear which urls it's using, and it's working nicely for me. |
Description:
When I was setting up
swag_ondemand, it occurred to me that I'm basically duplicating the same information in theswag_ondemand_urlslabel that I've already set inswag_urllabel to makeswag_auto_proxyso I figured it would make sense to do that automatically.Benefits of this PR and context:
It makes using
swag_ondemandandswag_auto_proxyslightly simpler to use together, and they already work great together. Plus it eliminates one place you might forget to update if you change the url of a container.How Has This Been Tested?
I've manually tested it with all the containers I have swag_ondemand configured. I added logging so that it's clear what it's doing, and it's working for me with labels like this:
Source / References: