Can we simplify this?

[poul250]

It looks verdy difficult

Ranges/cpp/Platform.Ranges/EnsureExtensions.h

Lines 33 to 43 in d7b5ac8

	public: template <typename TArgument> static void ArgumentInRange(Platform::Exceptions::ExtensionRoots::EnsureAlwaysExtensionRoot root, TArgument argumentValue, Range<TArgument> range, std::string argumentName, std::string message)
	{
	auto messageBuilder = [&]() -> std::string { return message; };
	ArgumentInRange(root, argumentValue, range, argumentName, messageBuilder);
	}
	public: template <typename TArgument> static void ArgumentInRange(Platform::Exceptions::ExtensionRoots::EnsureAlwaysExtensionRoot root, TArgument argumentValue, Range<TArgument> range, std::string argumentName)
	{
	auto messageBuilder = [&]() -> std::string { return std::string("Argument value [").append(Platform::Converters::To<std::string>(argumentValue)).append("] is out of range ").append(Platform::Converters::To<std::string>(range)).append(1, '.'); };
	ArgumentInRange(root, argumentValue, range, argumentName, messageBuilder);
	}

Why do we create lambdas, recursively descend into other functions, sums a bunch of lines to check that an element is in the range? And why do we throw an exception if the element is not in the range, when we can return a boolean value? Can we simplify this?

[uselessgoddess]

We can write noexcept

[konard]

The reason lambdas are used is lazy execution. We do not need to calculate the string until the exception is thrown.
This method called Ensure::Always::ArgumentInRange the reason it exists is to ensure the condition is met. If it is not, the exception is thrown. You can always use range.Contains method if you would like to check it yourself. This method returns boolean. If you need to throw an exception - use Ensure::Always::ArgumentInRange, if you don't want to use exceptions, just don't use this method.

[uselessgoddess]

The reason lambdas are used is lazy execution. We do not need to calculate the string until the exception is thrown.
This method called Ensure::Always::ArgumentInRange the reason it exists is to ensure the condition is met. If it is not, the exception is thrown. You can always use range.Contains method if you would like to check it yourself. This method returns boolean. If you need to throw an exception - use Ensure::Always::ArgumentInRange, if you don't want to use exceptions, just don't use this method.

Use std::string_view with static string messages for this