Merge pull request #3681 from alexandear-org/chore/lint-unconvert

chore: Enable unconvert linter

Author: AkihiroSuda

.golangci.yml

@@ -25,6 +25,7 @@ linters:
   - perfsprint
   - revive
   - staticcheck
+  - unconvert
   - unused
   - usetesting
   - whitespace

pkg/imgutil/nativeimgutil/nativeimgutil.go

@@ -163,7 +163,7 @@ func (n *NativeImageUtil) CreateDisk(disk string, size int64) error {
 	}
 	defer f.Close()
 	roundedSize := roundUp(size)
-	return f.Truncate(int64(roundedSize))
+	return f.Truncate(roundedSize)
 }
 
 // ConvertToRaw converts a disk image to raw format.

pkg/store/instance_windows.go

@@ -72,17 +72,16 @@ func GetWslStatus(instName string) (string, error) {
 		"--verbose",
 	})
 	if err != nil {
-		return "", fmt.Errorf("failed to run `wsl --list --verbose`, err: %w (out=%q)", err, string(out))
+		return "", fmt.Errorf("failed to run `wsl --list --verbose`, err: %w (out=%q)", err, out)
 	}
 
 	if out == "" {
 		return StatusBroken, fmt.Errorf("failed to read instance state for instance %q, try running `wsl --list --verbose` to debug, err: %w", instName, err)
 	}
 
 	// Check for edge cases first
-	outString := string(out)
-	if strings.Contains(outString, "Windows Subsystem for Linux has no installed distributions.") {
-		if strings.Contains(outString, "Wsl/WSL_E_DEFAULT_DISTRO_NOT_FOUND") {
+	if strings.Contains(out, "Windows Subsystem for Linux has no installed distributions.") {
+		if strings.Contains(out, "Wsl/WSL_E_DEFAULT_DISTRO_NOT_FOUND") {
 			return StatusBroken, fmt.Errorf(
 				"failed to read instance state for instance %q because no distro is installed,"+
 					"try running `wsl --install -d Ubuntu` and then re-running Lima", instName)
@@ -96,7 +95,7 @@ func GetWslStatus(instName string) (string, error) {
 	var instState string
 	wslListColsRegex := regexp.MustCompile(`\s+`)
 	// wsl --list --verbose may have different headers depending on localization, just split by line
-	for _, rows := range strings.Split(strings.ReplaceAll(string(out), "\r\n", "\n"), "\n") {
+	for _, rows := range strings.Split(strings.ReplaceAll(out, "\r\n", "\n"), "\n") {
 		cols := wslListColsRegex.Split(strings.TrimSpace(rows), -1)
 		nameIdx := 0
 		// '*' indicates default instance

pkg/windows/process_windows.go

@@ -29,7 +29,7 @@ func GetProcessCommandLine(name string) ([]string, error) {
 	}
 
 	var outJSON CommandLineJSON
-	if err = json.Unmarshal([]byte(out), &outJSON); err != nil {
+	if err = json.Unmarshal(out, &outJSON); err != nil {
 		return nil, fmt.Errorf("failed to unmarshal %q as %T: %w", out, outJSON, err)
 	}
 

pkg/wsl2/vm_windows.go

@@ -30,7 +30,7 @@ func startVM(ctx context.Context, distroName string) error {
 	}, executil.WithContext(ctx))
 	if err != nil {
 		return fmt.Errorf("failed to run `wsl.exe --distribution %s`: %w (out=%q)",
-			distroName, err, string(out))
+			distroName, err, out)
 	}
 	return nil
 }
@@ -48,7 +48,7 @@ func initVM(ctx context.Context, instanceDir, distroName string) error {
 	}, executil.WithContext(ctx))
 	if err != nil {
 		return fmt.Errorf("failed to run `wsl.exe --import %s %s %s`: %w (out=%q)",
-			distroName, instanceDir, baseDisk, err, string(out))
+			distroName, instanceDir, baseDisk, err, out)
 	}
 	return nil
 }
@@ -62,7 +62,7 @@ func stopVM(ctx context.Context, distroName string) error {
 	}, executil.WithContext(ctx))
 	if err != nil {
 		return fmt.Errorf("failed to run `wsl.exe --terminate %s`: %w (out=%q)",
-			distroName, err, string(out))
+			distroName, err, out)
 	}
 	return nil
 }
@@ -172,7 +172,7 @@ func unregisterVM(ctx context.Context, distroName string) error {
 	}, executil.WithContext(ctx))
 	if err != nil {
 		return fmt.Errorf("failed to run `wsl.exe --unregister %s`: %w (out=%q)",
-			distroName, err, string(out))
+			distroName, err, out)
 	}
 	return nil
 }