Support isEqualNode
#1246
Open
Support isEqualNode
#1246
+76
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Dec 5, 2025
| } | ||
|
|
||
| // TODO: Compare `localName` and prefix. | ||
| switch (self._type) { |
Collaborator
There was a problem hiding this comment.
Could push this logic into each type, e.g.
if (self.as(Element).isEqualNode(other.as(Element)) == false) {
return false;
}| const e1 = self.as(Element); | ||
| const e2 = other.as(Element); | ||
|
|
||
| const e1_tag = e1.getTagNameSpec(&page.buf); |
Collaborator
There was a problem hiding this comment.
I think you can use getTagNameDump() instead, which doesn't require a buffer
| return false; | ||
| } | ||
|
|
||
| if (e1._namespace != e2._namespace or !std.mem.eql(u8, e1_tag, e2_tag) or iter1_count != iter2_count) { |
Collaborator
There was a problem hiding this comment.
Both more efficient and easier to read if you group these a little better. Check the tags names and namespaces where you get them, before iterating through all the attributes and comparing htem.
|
|
||
| return std.mem.eql(u8, c1.getData(), c2.getData()); | ||
| }, | ||
| else => @panic("NIY"), |
Collaborator
There was a problem hiding this comment.
log.warn(.browser, "not implemented", .{
.type = self._type,
.feature = "Node.isEqualNode",
});
return false;
| else => @panic("NIY"), | ||
| } | ||
|
|
||
| // `Node.childNodes` allocate memory, this seems like a better option. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // `Node.childNodes` allocate memory, this seems like a better option. |
Collaborator
There was a problem hiding this comment.
Yes, childrenIterator is meant for internal iteration within the Zig code, specifically to avoid the overhead of childNodes necessary to fulfill the webapi of that type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bare minimum required for a specific website, I'll add support for other variants once needed.