Add enable_htlc_hold cfg flag + fail hold htlcs

As part of supporting sending payments as an often-offline sender, the
often-offline sender's channel counterparty needs to advertise a feature bit
indicating that they support holding onto the sender's HTLC until they receive
a release_held_htlc onion message from the recipient indicating that they are
online and ready to receive the payment.

Here we add a config flag to turn on advertising this feature, and fail back
hold_htlcs if this config flag is not set.

See-also <lightning/bolts#989>

Author: valentinewallace

lightning/src/ln/channelmanager.rs

@@ -6420,6 +6420,32 @@ where
 					});
 				let shared_secret = next_hop.shared_secret().secret_bytes();
 
+				// Nodes shouldn't expect us to hold HTLCs for them if we don't advertise htlc_hold feature
+				// support.
+				//
+				// If we wanted to pretend to be a node that didn't understand the feature at all here, the
+				// correct behavior would've been to disconnect the sender when we first received the
+				// update_add message. However, this would make the `UserConfig::enable_htlc_hold` option
+				// unsafe -- if our node switched the config option from on to off just after the sender
+				// enqueued their update_add + CS, the sender would continue retransmitting those messages
+				// and we would keep disconnecting them until the HTLC timed out.
+				if update_add_htlc.hold_htlc.is_some()
+					&& !BaseMessageHandler::provided_node_features(self).supports_htlc_hold()
+				{
+					let reason = LocalHTLCFailureReason::TemporaryNodeFailure;
+					let htlc_fail = self.htlc_failure_from_update_add_err(
+						&update_add_htlc,
+						&incoming_counterparty_node_id,
+						reason,
+						is_intro_node_blinded_forward,
+						&shared_secret,
+					);
+					let failure_type =
+						get_htlc_failure_type(outgoing_scid_opt, update_add_htlc.payment_hash);
+					htlc_fails.push((htlc_fail, failure_type, reason.into()));
+					continue;
+				}
+
 				// Process the HTLC on the incoming channel.
 				match self.do_funded_channel_callback(
 					incoming_scid,
@@ -14847,6 +14873,13 @@ pub fn provided_init_features(config: &UserConfig) -> InitFeatures {
 		features.set_anchor_zero_fee_commitments_optional();
 	}
 
+	// If we are configured to be an announced node, we are expected to be always-online and can
+	// advertise the htlc_hold feature.
+	#[cfg(test)]
+	if config.enable_htlc_hold {
+		features.set_htlc_hold_optional();
+	}
+
 	features
 }
 

lightning/src/util/config.rs

@@ -935,6 +935,18 @@ pub struct UserConfig {
 	///
 	/// Default value: `false`
 	pub enable_dual_funded_channels: bool,
+	/// LDK supports a feature for always-online nodes such that these nodes can hold onto an HTLC
+	/// from an often-offline channel peer until the often-offline payment recipient sends an onion
+	/// message telling the always-online node to release the HTLC. If this is set to `true`, our node
+	/// will carry out this feature for channel peers that request it.
+	///
+	/// This should only be set to `true` for nodes which expect to be online reliably.
+	///
+	/// Setting this to `true` may break backwards compatibility with LDK versions < 0.2.
+	///
+	/// Default value: `false`
+	#[cfg(test)]
+	pub enable_htlc_hold: bool,
 }
 
 impl Default for UserConfig {
@@ -949,6 +961,8 @@ impl Default for UserConfig {
 			accept_intercept_htlcs: false,
 			manually_handle_bolt12_invoices: false,
 			enable_dual_funded_channels: false,
+			#[cfg(test)]
+			enable_htlc_hold: false,
 		}
 	}
 }