Skip to content

Conversation

@ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Nov 27, 2025

This is a new life for #41 (opened in Nov 2022 and abandoned since) and the project!
The PR's version of the site is currently deployed at https://ulysses4ever.github.io/learnyouahaskell.github.io/.
Sadly, because of the many changes, both structural and little but pervasive, the HTML diff isn't very useful. (The Markdown diff is useful.) Hence, the reviewers are advised to open and eyeball the deployed version.

Below I detail main changes that this PR brings.

Main Changes

[1] Makes HTML generated from /markdown/source_md straight to /docs with Pandoc (which becomes a dependency of the project).

  • use the new Makefile to generate the HTML (make) and to clean it up (make clean).

[2] Removes all HTML files that can be generated: docs/*.html and markdown/generated_html, except docs/index.html. Also removes markdown/generated_md (only used as a temporary directory really). This was a HUGE point of confusion for external contributors --- having several versions of the same thing.

How's HTML

[3] There are many small changes to the generated HTML vs the current one mostly because the current one is pretty irregular (no closing </p> tags, some weird combination of p and img tags, etc.). The many changes are meticulously recorded in the commit history inherited from #41.

Visually the result looks almost the same (please, double-check!), modulo slight changes in how text flows around images, but that doesn't seem consequential in any way.

How's CSS

[4] There doesn't seem be any changes on main since #41 was forked except for the responsiveness PR #64, which I manually applied.

How's textual content

[5] There has been many little text changes since #41 was forked. @pierluc-codes carefully re-implemented them here and I cross-chcecked it.

Minor cleanups and updates

[6] GitHub Workflow will now deploy the website by generating HTML from MD (obviously).

[7] generate.sh was cleaned up a bit, including with shellcheck.

  • future TODO: create a CI workflow to check that shellcheck is clean.

[8] there was duplication of style.css/reset.css (they lived both under /docs and under /docs/assets/css). There's now only one version (/docs/assets/css).

[9] Similar to [8], JS files for the syntax highlighter that lived under /docs were moved to a more appropriate place under /docs/sh (the directory was there before and held one file already).

[10] The new .gitignore excludes the generated files under /docs.


old description

TODO:


The current version is rendered here: https://ulysses4ever.github.io/learnyouahaskell.github.io/chapters.html Note for @pierluc-codes : I had to change the repository I worked from (it used to be ulysses4ever/learnyouahaskell-md) because I cant open pull requests from non-forks.

Gregory Cox and others added 30 commits March 21, 2023 03:25
Signed-off-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
@ulysses4ever ulysses4ever marked this pull request as ready for review December 8, 2025 04:57
@ulysses4ever ulysses4ever changed the title WIP: Switch to Markdown Switch to Markdown Dec 8, 2025
@ulysses4ever
Copy link
Collaborator Author

I intended to do more spot-checking but this PR is ready for review now. @pierluc-codes

@@ -1,3 +1,4 @@
from: markdown-implicit_figures
to: html
highlight-style: null
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierluc-codes this was in the original PR and you removed it recently. I'm not sure what's going on here: I haven't studied this Pasndoc option. My guess would be that we make sure Pandoc doesn't try to highlight anything because we supply our own JS highlighter. The result seem fine with this option at least?

@ulysses4ever
Copy link
Collaborator Author

I made a big final sweep and this is ready for review now. This is a big change, so I'll ping all codeowners hoping to get more eyes on it. The result would benefit from eyeballing more. I also update this PR's description (see at the top) with a list of notable changes. Please, check it out...

It'd be good to merge it this week because there are many PR's on the repo that will benefit from rebasing on this.

@smith558
@konsumlamm
@xogcox
@memowe
@pierluc-codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants