refactor: moves appConfigImportRegex to utils package, and resolves them in esbuild plugin

Author: joelgallant

app-config-esbuild/src/index.ts

@@ -1,7 +1,7 @@
 import type { Plugin } from 'esbuild';
 import path from 'path';
 import { ConfigLoadingOptions, loadValidatedConfig } from '@app-config/config';
-import { generateModuleText, packageNameRegex } from '@app-config/utils';
+import { appConfigImportRegex, generateModuleText, packageNameRegex } from '@app-config/utils';
 import type { SchemaLoadingOptions } from '@app-config/schema';
 
 export interface Options {
@@ -24,6 +24,11 @@ export const createPlugin = ({
       namespace: '@app-config/esbuild',
     }));
 
+    build.onResolve({ filter: appConfigImportRegex }, (args) => ({
+      path: args.path,
+      namespace: '@app-config/esbuild',
+    }));
+
     build.onLoad({ filter: /.*/, namespace: '@app-config/esbuild' }, async () => {
       const { fullConfig, environment, validationFunctionCode, filePaths } =
         await loadValidatedConfig(loadingOptions, schemaLoadingOptions);

app-config-rollup/src/index.ts

@@ -1,5 +1,5 @@
 import type { Plugin } from 'rollup';
-import { generateModuleText, packageNameRegex } from '@app-config/utils';
+import { appConfigImportRegex, generateModuleText, packageNameRegex } from '@app-config/utils';
 import { ConfigLoadingOptions, loadValidatedConfig } from '@app-config/config';
 import type { SchemaLoadingOptions } from '@app-config/schema';
 
@@ -13,10 +13,6 @@ export interface Options {
   readGlobal?: boolean;
 }
 
-// vite resolves first before passing to the rollup plugin
-export const appConfigImportRegex =
-  /(app-config|app-config-main|@app-config\/main)\/dist(\/es)?\/index\.js/;
-
 export default function appConfigRollup(
   options: Options = {},
 ): Plugin & { currentFilePaths?: string[] } {

app-config-utils/src/index.ts

@@ -7,6 +7,9 @@ export const isWindows = isNode && /^win/.test(process.platform);
 export const packageNameRegex =
   /(^@(lcdev|servall)\/app-config)|(^@app-config\/main)|(\.?app-config(\.\w+)?\.(toml|yml|yaml|json|json5))|(\.config-placeholder)/;
 
+export const appConfigImportRegex =
+  /(app-config|app-config-main|@app-config\/main)\/dist(\/es)?\/index\.js/;
+
 export type JsonPrimitive = number | string | boolean | null;
 
 export interface JsonObject {