Update code.py

blondon1 · web-flow · commit 50b115d9ebda · 2024-01-31T10:50:14.000-05:00
Instead of printing to the console, consider using the logging module for better logging management, try-except blocks to handle potential errors during the SMTP connection and email sending process, environment variables, context managers and improved handle attachments to avoid runtime errors
diff --git a/AUTOMATION/Sending-Emails/code.py b/AUTOMATION/Sending-Emails/code.py
@@ -1,36 +1,44 @@
-###### Notice ######
-
-# before sending email you have to enable your less secure apps access in your sending mail (xyz@gmail.com)
-
 import smtplib
+import os
 from email.message import EmailMessage
-
-EMAIL_ADDRESS = "xyz@gmail.com"                         # your email-id goes here
-EMAIL_PASSWORD = "xyz"                                  # your password goes here
-
-msg = EmailMessage()
-msg['Subject'] = 'this is subject'
-msg['From'] = EMAIL_ADDRESS
-msg['To'] = EMAIL_ADDRESS
-
-msg.set_content('Content area')
-
-msg.add_alternative("""\
-<html>
-<body>
-    <h1>Your HTML CONTENT GOES HERE </h1>                                
-</body>
-</html>
-""", subtype='html')
-
-with open('testing.txt', 'rb') as f:                       # your filename will go here
-    file_data = f.read()
-    file_name = f.name
-
-    msg.add_attachment(file_data, maintype='application', subtype='octet-stream', filename=file_name)
-
-with smtplib.SMTP_SSL('smtp.gmail.com', 465) as smtp:
-    smtp.login(EMAIL_ADDRESS, EMAIL_PASSWORD)
-
-    smtp.send_message(msg)
-    print("Email Sent Successfully ..")
+import logging
+
+# Set up logging
+logging.basicConfig(level=logging.INFO)
+
+# Use environment variables for credentials
+EMAIL_ADDRESS = os.getenv('EMAIL_ADDRESS')  
+EMAIL_PASSWORD = os.getenv('EMAIL_PASSWORD')  
+
+def send_email(subject, recipient, body, html_content=None, attachment_path=None):
+    msg = EmailMessage()
+    msg['Subject'] = subject
+    msg['From'] = EMAIL_ADDRESS
+    msg['To'] = recipient
+
+    msg.set_content(body)
+
+    if html_content:
+        msg.add_alternative(html_content, subtype='html')
+
+    if attachment_path:
+        try:
+            with open(attachment_path, 'rb') as f:
+                file_data = f.read()
+                file_name = f.name
+                msg.add_attachment(file_data, maintype='application', subtype='octet-stream', filename=file_name)
+        except FileNotFoundError:
+            logging.error(f"Attachment file {attachment_path} not found.")
+            return
+
+    try:
+        with smtplib.SMTP_SSL('smtp.gmail.com', 465) as smtp:
+            smtp.login(EMAIL_ADDRESS, EMAIL_PASSWORD)
+            smtp.send_message(msg)
+            logging.info("Email Sent Successfully")
+    except Exception as e:
+        logging.error(f"An error occurred: {e}")
+
+# Usage Example
+send_email('Test Subject', 'recipient@example.com', 'This is the email body',
+           '<html><body><h1>HTML Content</h1></body></html>', 'testing.txt')
