Lens CSV export empty when query ID is not the same as resource model ID

[moisessepulveda]

• Laravel Version: 9.11
• Nova Version: 4.15.1
• PHP Version: 8.1
• Database Driver & Version: Postgres 14
• Operating System and Version: MAC OS 12.4
• Browser type and version: Safari 15.5
• Reproduction Repository: https://github.com/moisessepulveda/nova-lens-bug-report

Description:

When you we have a lens that contains a group by and you try to export data as CSV, it doesn't work when you select individual record. It only works when "Select all" is selected.

This issue only happens when primary key obtained from query does not belongs to the same model as resource.

Detailed steps to reproduce the issue on a fresh Nova installation:

First keep in mind and create the next two models:

Employee:

column	type
id	integer
name	string

Payment:

column	type
id	integer
amount	integer
employee_id	integer

• Create Resource for every model.
• Create a lens that contains a group by. The primary key obtained from the query should come from another table different than resource one.
• We will create a Payment Lens that will obtain how many payments every employee has. Something like this:

employee id	name	payments
1	jack sparrow	5
2	jane doe	10
3	jhon doe	20

Consider a query like this:

/**
     * Get the query builder / paginator for the lens.
     *
     * @param  \Laravel\Nova\Http\Requests\LensRequest  $request
     * @param  \Illuminate\Database\Eloquent\Builder  $query
     * @return mixed
     */
    public static function query(LensRequest $request, $query)
    {
        return $request->withOrdering($request->withFilters(
            $query->select('employees.id', 'employees.name', DB::raw('count(payments.id) as count'))
            ->join('employees', 'payments.employee_id', '=', 'employees.id')
            ->groupBy('employees.id', 'employees.name')
        ));
    }

fields:

public function fields(NovaRequest $request)
    {
        return [
            ID::make(__('ID'), 'id')->sortable(),
            Text::make('Name', 'name'),
            Number::make('Count', 'count')
        ];
    }

actions:

public function actions(NovaRequest $request)
    {
        return [
            ExportAsCsv::make(__('Exportar a CSV'))->withFormat(function ($model) {
                return [
                    'id' => $model->id,
                    'Name' => $model->name,
                    'Count' => $model->count,
                ];
            })
        ];
    }

• IMPORTANT Add this LENS to Payment Resource.
• Use exportAsCSV Facade exporting the related data.
• Open Nova admin panel, then go to payment resource and open the lens just created.
• Try to export individual record using Export as CSV action.
• You will note that CSV actually is downloaded, but it completely empty.
• If you try "Select all" and then try to export is works like a charm.

[crynobone]

At the moment there's no reliable way to identify resourceIds when Lens query doesn't use the resource default ID https://github.com/laravel/nova/blob/96d4481cfd5bd4406212487e17838fd6bc261f6e/src/Http/Requests/ActionRequest.php#L118-L121 and this wouldn't be an easy fix.

If you can accept to export CSV for "select all" until we can come up with a solution then you can use the following:

    public function lenses(Request $request): array
    {
        return [
            PaymentsPerEmployee::make()->canSee(function ($request) {
                return $request->allResourcesSelected();
            }),
        ];
    }

[moisessepulveda]

Thanks for the answer, I hope you can find a solution soon. I'll stick with the workaround proposal for the moment