DependsOn stops fillUsing working

[anthony-brindley]

• Laravel Version: 9.8.1
• Nova Version: 4.2.1

Description:

When you have a fillUsing method and a dependsOn method on the same field, the fillUsing doesn't populate an attribute of the model. Removing the dependsOn fixes the issue.

Detailed steps to reproduce the issue on a fresh Nova installation:

• Create a Model with a resource.
• Add a 2 Text Fields
• On the 2nd field add a fillUsing method. In my example I have simply dd'd something to demonstrate the method is being run
• On the 2nd field add a dependsOn method. In my example I have made the field readonly if the 1st field equals 0;
• try submitting the form
• with both the dependsOn and fillUsing, the form will submit and bypass the fill using.
• remove the dependsOn
• try submitting the form
• the network tab will show the dd worked demonstrating that the fillUsing method was called

Screenshot of my code: https://www.dropbox.com/s/z90i1xju2pwwefy/phpstorm64_2022-04-15_10-46-07.png?dl=0

Video: https://www.dropbox.com/s/ufx4w4yjv17lyl0/chrome_2022-04-15_10-48-53.mp4?dl=0

[crynobone]

Updating dependsOn() doesn't triggerfillUsing(). That only happened during actual database save.

[anthony-brindley]

But fillUsing should be triggered when you submit the form, every time shouldn't it so you can correctly populate the database based on the value of the field? I don't understand why it would be one or the other? For instance, I am using dependsOn to populate the options available in a select field, which will update when the parent is changed.

In my real use case instance (not the mock), the i am looking to set an attribute on my model so I can pick it up on my observer and trigger an action if it's not null. Because fillUsing is not being triggered everytime, I am unable to consistently react to form submission.

[anthony-brindley]

So my real use case is Parent Field (Manufacturer). When changed, the Child (CarModel) updates it options to make all CarModels stored in the system for that Manufacturer available. If the user wants to add a CarModel, they should select 'New Model' which is an extra option I added into the option array. When this CarModel field is set to 'New Model', I have a text box, which is set to dependOn the CarModel field being 'New Model' - when this is the case it becomes editable.

When the form is then submitted, I am looking for the new_model attribute and I can take an action to persist the model_name and get an id and update the correct attribute on the formData before persisting the Car. Because the dependsOn is not allowing the fillUsing to work, this isn't working and I think it's a bug, rather than a feature request because you would expect the fillUsing method to be called 100% of the time, irrelevant of other methods on the field?

[anthony-brindley]

Oh, and just to clarify, I submitted the form on both occasions to trigger a database save in my video. FillUsing was not actioned when the dependsOn was.