Refactor

Author: pushpak1300

src/Server.php

@@ -36,6 +36,14 @@
  */
 abstract class Server
 {
+    public const CAPABILITY_TOOLS = 'tools';
+
+    public const CAPABILITY_RESOURCES = 'resources';
+
+    public const CAPABILITY_PROMPTS = 'prompts';
+
+    public const CAPABILITY_COMPLETTIONS = 'completions';
+
     protected string $name = 'Laravel MCP Server';
 
     protected string $version = '0.0.1';
@@ -58,13 +66,13 @@ abstract class Server
      * @var array<string, array<string, bool>|stdClass|string>
      */
     protected array $capabilities = [
-        'tools' => [
+        self::CAPABILITY_TOOLS => [
             'listChanged' => false,
         ],
-        'resources' => [
+        self::CAPABILITY_RESOURCES => [
             'listChanged' => false,
         ],
-        'prompts' => [
+        self::CAPABILITY_PROMPTS => [
             'listChanged' => false,
         ],
     ];

src/Server/Methods/CompletionComplete.php

@@ -7,6 +7,7 @@
 use Illuminate\Container\Container;
 use Illuminate\Support\Arr;
 use InvalidArgumentException;
+use Laravel\Mcp\Server;
 use Laravel\Mcp\Server\Contracts\HasUriTemplate;
 use Laravel\Mcp\Server\Contracts\Method;
 use Laravel\Mcp\Server\Contracts\SupportsCompletion;
@@ -26,7 +27,7 @@ class CompletionComplete implements Method
 
     public function handle(JsonRpcRequest $request, ServerContext $context): JsonRpcResponse
     {
-        if (! isset($context->serverCapabilities['completions'])) {
+        if (! $context->hasCapability(Server::CAPABILITY_COMPLETTIONS)) {
             throw new JsonRpcException(
                 'Server does not support completions capability.',
                 -32601,
@@ -54,13 +55,13 @@ public function handle(JsonRpcRequest $request, ServerContext $context): JsonRpc
         if (! $primitive instanceof SupportsCompletion) {
             throw new JsonRpcException(
                 'The referenced primitive does not support completion.',
-                -32602,
+                -32601,
                 $request->id,
             );
         }
 
-        $argumentName = $argument['name'] ?? null;
-        $argumentValue = $argument['value'] ?? '';
+        $argumentName = Arr::get($argument, 'name');
+        $argumentValue = Arr::get($argument, 'value', '');
 
         if (is_null($argumentName)) {
             throw new JsonRpcException(

src/Server/Methods/Concerns/ResolvesPrompts.php

@@ -12,7 +12,7 @@ trait ResolvesPrompts
 {
     protected function resolvePrompt(?string $name, ServerContext $context): Prompt
     {
-        if (is_null($name)) {
+        if (! $name) {
             throw new InvalidArgumentException('Missing [name] parameter.');
         }
 

src/Server/ServerContext.php

@@ -83,6 +83,11 @@ public function perPage(?int $requestedPerPage = null): int
         return min($requestedPerPage ?? $this->defaultPaginationLength, $this->maxPaginationLength);
     }
 
+    public function hasCapability(string $capability): bool
+    {
+        return array_key_exists($capability, $this->serverCapabilities);
+    }
+
     /**
      * @template T of Primitive
      *