fix: CI golangci-lint errors (#1948)

* Upgraded golangci-lint to fix CI build errors

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Fix lint errors

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

---------

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

Author: shmuelk

Makefile

@@ -406,7 +406,7 @@ KUSTOMIZE_VERSION ?= v5.4.3
 CONTROLLER_TOOLS_VERSION ?= v0.19.0
 ENVTEST_VERSION ?= release-0.19
 CRD_REF_DOCS_VERSION ?= v0.2.0
-GOLANGCI_LINT_VERSION ?= v2.3.0
+GOLANGCI_LINT_VERSION ?= v2.7.0
 HELM_VERSION ?= v3.17.1
 KUBECTL_VALIDATE_VERSION ?= v0.0.4
 GCI_VERSION ?= v0.13.6

apix/config/v1alpha1/endpointpickerconfig_types.go

@@ -19,6 +19,7 @@ package v1alpha1
 import (
 	"encoding/json"
 	"fmt"
+	"strings"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -139,11 +140,12 @@ func (fg FeatureGates) String() string {
 		return "{}"
 	}
 
-	result := ""
+	builder := strings.Builder{}
 	for _, gate := range fg {
-		result += gate + ","
+		builder.WriteString(gate + ",")
 	}
 
+	result := builder.String()
 	if len(result) > 0 {
 		result = result[:len(result)-1]
 	}

conformance/utils/kubernetes/helpers.go

@@ -22,6 +22,7 @@ import (
 	"context"
 	"fmt"
 	"reflect"
+	"strings"
 	"testing"
 	"time"
 
@@ -131,19 +132,21 @@ func InferencePoolMustHaveCondition(t *testing.T, c client.Reader, poolNN types.
 			if len(lastObservedPool.Status.Parents) == 0 {
 				debugMsg += " (No parent statuses reported)"
 			}
+			builder := strings.Builder{}
 			for i, parentStatus := range lastObservedPool.Status.Parents {
 				namespace := parentStatus.ParentRef.Namespace
 				if namespace == "" {
 					namespace = inferenceapi.Namespace(poolNN.Namespace) // Fallback to the pool's namespace
 				}
-				debugMsg += fmt.Sprintf("\n  Parent %d (Gateway: %s/%s):", i, namespace, parentStatus.ParentRef.Name)
+				fmt.Fprintf(&builder, "\n  Parent %d (Gateway: %s/%s):", i, namespace, parentStatus.ParentRef.Name)
 				if len(parentStatus.Conditions) == 0 {
-					debugMsg += " (No conditions reported for this parent)"
+					builder.WriteString(" (No conditions reported for this parent)")
 				}
 				for _, cond := range parentStatus.Conditions {
-					debugMsg += fmt.Sprintf("\n    - Type: %s, Status: %s, Reason: %s, Message: %s", cond.Type, cond.Status, cond.Reason, cond.Message)
+					fmt.Fprintf(&builder, "\n    - Type: %s, Status: %s, Reason: %s, Message: %s", cond.Type, cond.Status, cond.Reason, cond.Message)
 				}
 			}
+			debugMsg += builder.String()
 		} else if lastError == nil || !apierrors.IsNotFound(lastError) {
 			debugMsg += "\nInferencePool was not found or not observed successfully during polling."
 		}