Skip to content

Commit f1c21c4

Browse files
authored
Merge pull request #13168 from fabriziopandini/use-envtest-1.35
🌱 Use env test 1.35.0
2 parents ff48671 + d5a7455 commit f1c21c4

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export GO111MODULE=on
4444
#
4545
# Kubebuilder.
4646
#
47-
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.34.0
47+
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.35.0
4848
export KUBEBUILDER_CONTROLPLANE_START_TIMEOUT ?= 60s
4949
export KUBEBUILDER_CONTROLPLANE_STOP_TIMEOUT ?= 60s
5050

internal/webhooks/test/machinedrainrules_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ func Test_validate(t *testing.T) {
191191
},
192192
},
193193
wantErr: "MachineDrainRule.cluster.x-k8s.io \"mdr\" is invalid: " +
194-
"spec.machines: Invalid value: \"array\": entries in machines must be unique",
194+
"spec.machines: Invalid value: entries in machines must be unique",
195195
},
196196
{
197197
name: "Return error if pod selectors are not unique",
@@ -233,7 +233,7 @@ func Test_validate(t *testing.T) {
233233
},
234234
},
235235
wantErr: "MachineDrainRule.cluster.x-k8s.io \"mdr\" is invalid: " +
236-
"spec.pods: Invalid value: \"array\": entries in pods must be unique",
236+
"spec.pods: Invalid value: entries in pods must be unique",
237237
},
238238
}
239239

internal/webhooks/test/machinehealthcheck_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func Test_validateMachineHealthCheck(t *testing.T) {
8484
},
8585
},
8686
wantErr: "MachineHealthCheck.cluster.x-k8s.io \"mhc\" is invalid: " +
87-
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"string\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
87+
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"Ready\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
8888
},
8989
{
9090
name: "Return error if UnhealthyMachineCondition type is 'Available'",
@@ -112,7 +112,7 @@ func Test_validateMachineHealthCheck(t *testing.T) {
112112
},
113113
},
114114
wantErr: "MachineHealthCheck.cluster.x-k8s.io \"mhc\" is invalid: " +
115-
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"string\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
115+
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"Available\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
116116
},
117117
{
118118
name: "Return error if UnhealthyMachineCondition type is 'HealthCheckSucceeded'",
@@ -140,7 +140,7 @@ func Test_validateMachineHealthCheck(t *testing.T) {
140140
},
141141
},
142142
wantErr: "MachineHealthCheck.cluster.x-k8s.io \"mhc\" is invalid: " +
143-
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"string\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
143+
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"HealthCheckSucceeded\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
144144
},
145145
{
146146
name: "Return error if UnhealthyMachineCondition type is 'OwnerRemediated'",
@@ -168,7 +168,7 @@ func Test_validateMachineHealthCheck(t *testing.T) {
168168
},
169169
},
170170
wantErr: "MachineHealthCheck.cluster.x-k8s.io \"mhc\" is invalid: " +
171-
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"string\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
171+
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"OwnerRemediated\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
172172
},
173173
{
174174
name: "Return error if UnhealthyMachineCondition type is 'ExternallyRemediated'",
@@ -196,7 +196,7 @@ func Test_validateMachineHealthCheck(t *testing.T) {
196196
},
197197
},
198198
wantErr: "MachineHealthCheck.cluster.x-k8s.io \"mhc\" is invalid: " +
199-
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"string\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
199+
"spec.checks.unhealthyMachineConditions[0].type: Invalid value: \"ExternallyRemediated\": type must not be one of: Ready, Available, HealthCheckSucceeded, OwnerRemediated, ExternallyRemediated",
200200
},
201201
{
202202
name: "Return no error if UnhealthyMachineCondition type is allowed custom type",

0 commit comments

Comments
 (0)