From fcadd376a70bbf4c150ce724b7aec525f1b3c3ff Mon Sep 17 00:00:00 2001 From: Ivan Josipovic <9521987+IvanJosipovic@users.noreply.github.com> Date: Tue, 2 Dec 2025 17:43:51 -0800 Subject: [PATCH 1/2] fix: make JsonConverter classes public --- src/KubernetesClient.Aot/V1PatchJsonConverter.cs | 2 +- src/KubernetesClient/Models/IntOrStringJsonConverter.cs | 2 +- src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs | 2 +- src/KubernetesClient/Models/V1PatchJsonConverter.cs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/KubernetesClient.Aot/V1PatchJsonConverter.cs b/src/KubernetesClient.Aot/V1PatchJsonConverter.cs index 314ef5694..8afaed297 100644 --- a/src/KubernetesClient.Aot/V1PatchJsonConverter.cs +++ b/src/KubernetesClient.Aot/V1PatchJsonConverter.cs @@ -1,7 +1,7 @@ namespace k8s.Models { #pragma warning disable CA1812 // Avoid uninstantiated internal classes - internal sealed class V1PatchJsonConverter : JsonConverter + public sealed class V1PatchJsonConverter : JsonConverter #pragma warning restore CA1812 // Avoid uninstantiated internal classes { public override V1Patch Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) diff --git a/src/KubernetesClient/Models/IntOrStringJsonConverter.cs b/src/KubernetesClient/Models/IntOrStringJsonConverter.cs index c7cbe273a..fe01f18dd 100644 --- a/src/KubernetesClient/Models/IntOrStringJsonConverter.cs +++ b/src/KubernetesClient/Models/IntOrStringJsonConverter.cs @@ -1,6 +1,6 @@ namespace k8s.Models { - internal sealed class IntOrStringJsonConverter : JsonConverter + public sealed class IntOrStringJsonConverter : JsonConverter { public override IntOrString Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) { diff --git a/src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs b/src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs index a99eb334b..9034c9f14 100644 --- a/src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs +++ b/src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs @@ -1,6 +1,6 @@ namespace k8s.Models { - internal sealed class ResourceQuantityJsonConverter : JsonConverter + public sealed class ResourceQuantityJsonConverter : JsonConverter { // https://github.com/kubernetes/apimachinery/blob/4b14f804a0babdcc58e695d72f77ad29f536511e/pkg/api/resource/quantity.go#L683 public override ResourceQuantity Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) diff --git a/src/KubernetesClient/Models/V1PatchJsonConverter.cs b/src/KubernetesClient/Models/V1PatchJsonConverter.cs index a8db06961..4108dd646 100644 --- a/src/KubernetesClient/Models/V1PatchJsonConverter.cs +++ b/src/KubernetesClient/Models/V1PatchJsonConverter.cs @@ -1,6 +1,6 @@ namespace k8s.Models { - internal sealed class V1PatchJsonConverter : JsonConverter + public sealed class V1PatchJsonConverter : JsonConverter { public override V1Patch Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) { From 4659415e766e0bb3936b9af0ad9c8f1611453710 Mon Sep 17 00:00:00 2001 From: Ivan Josipovic <9521987+IvanJosipovic@users.noreply.github.com> Date: Tue, 2 Dec 2025 18:10:03 -0800 Subject: [PATCH 2/2] chore: remove uneeded pragma warning --- src/KubernetesClient.Aot/V1PatchJsonConverter.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/KubernetesClient.Aot/V1PatchJsonConverter.cs b/src/KubernetesClient.Aot/V1PatchJsonConverter.cs index 8afaed297..5e3b94cd1 100644 --- a/src/KubernetesClient.Aot/V1PatchJsonConverter.cs +++ b/src/KubernetesClient.Aot/V1PatchJsonConverter.cs @@ -1,8 +1,6 @@ namespace k8s.Models { -#pragma warning disable CA1812 // Avoid uninstantiated internal classes public sealed class V1PatchJsonConverter : JsonConverter -#pragma warning restore CA1812 // Avoid uninstantiated internal classes { public override V1Patch Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) {