From c6a01d619ac56fb0cc80d7cb4e3b1797d16a2d8f Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+ktf@users.noreply.github.com> Date: Fri, 3 Oct 2025 13:47:32 +0200 Subject: [PATCH 1/2] DPL: do not rate limit giving back the resources Can cause an issue if said resources are needed to complete the timeframe. --- Framework/Core/src/ArrowSupport.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Framework/Core/src/ArrowSupport.cxx b/Framework/Core/src/ArrowSupport.cxx index a289980349924..623056cccd903 100644 --- a/Framework/Core/src/ArrowSupport.cxx +++ b/Framework/Core/src/ArrowSupport.cxx @@ -284,10 +284,10 @@ o2::framework::ServiceSpec ArrowSupport::arrowBackendSpec() unchangedCount++; } changedCountMetric(driverMetrics, unchangedCount, timestamp); - auto maxTimeframes = registry.get().maxTimeframes; - if (maxTimeframes && (totalTimeframesRead - totalTimeframesConsumed) > maxTimeframes) { - return; - } + //auto maxTimeframes = registry.get().maxTimeframes; + //if (maxTimeframes && (totalTimeframesRead - totalTimeframesConsumed) > maxTimeframes) { + // return; + //} static int64_t MAX_SHARED_MEMORY = calculateAvailableSharedMemory(registry); constexpr int64_t MAX_QUANTUM_SHARED_MEMORY = 100; From 65e205b84ecbca6b87ef76409b68542a02dbef8d Mon Sep 17 00:00:00 2001 From: ALICE Action Bot Date: Fri, 3 Oct 2025 11:49:16 +0000 Subject: [PATCH 2/2] Please consider the following formatting changes --- Framework/Core/src/ArrowSupport.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Framework/Core/src/ArrowSupport.cxx b/Framework/Core/src/ArrowSupport.cxx index 623056cccd903..bdd79614f24aa 100644 --- a/Framework/Core/src/ArrowSupport.cxx +++ b/Framework/Core/src/ArrowSupport.cxx @@ -284,10 +284,10 @@ o2::framework::ServiceSpec ArrowSupport::arrowBackendSpec() unchangedCount++; } changedCountMetric(driverMetrics, unchangedCount, timestamp); - //auto maxTimeframes = registry.get().maxTimeframes; - //if (maxTimeframes && (totalTimeframesRead - totalTimeframesConsumed) > maxTimeframes) { - // return; - //} + // auto maxTimeframes = registry.get().maxTimeframes; + // if (maxTimeframes && (totalTimeframesRead - totalTimeframesConsumed) > maxTimeframes) { + // return; + // } static int64_t MAX_SHARED_MEMORY = calculateAvailableSharedMemory(registry); constexpr int64_t MAX_QUANTUM_SHARED_MEMORY = 100;