Skip to content

Commit b83f5d2

Browse files
committed
ajust zip file for lui, update copilot merging instructions
1 parent d0c77d9 commit b83f5d2

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

.github/copilot-instructions.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,15 @@ ssh-add /home/stefan/.ssh/id_ed25519_github_hetzner"
99
5. You must compute a list of folders that are affected by the PR. Can be a single folder or can be many folders. Example: If the files "package.json" and "package-lock.json" in frameworks/keyed/angular and "package.json" in "frameworks/non-keyed/react" are changed the list is "keyed/angular non-keyed/react", so you leave out the frameworks directory and only report the directory names. This list in the argument for the next step.
1010
Always print the list.
1111
Check if there are changed to files in the webdriver-ts folder (e.g. webdriver-ts/results.json). If so make sure to eliminate those changes by using `git checkout` to restore the original versions such they don't end in the main branch when merging.
12-
6. If for each changed directory both package.json and package-lock.json are changed in the PR you must use `npm run rebuild-ci {list of framework-paths}`. Otherwise you must use `npm run rebuild {list of framework-path}` otherwise. You must concatenate all the directories with changes (which you computed above) in a format like "keyed/angular non-keyed/react"
12+
6. If for each changed directory both package.json and package-lock.json are changed in the PR you must use `npm run rebuild-ci {list of framework-paths}`. Otherwise you must use `npm run rebuild {list of framework-path}` otherwise. You must concatenate all the directories with changes (which you computed above) in a format like "keyed/angular non-keyed/react".
13+
You must also run the rebuild step for non javascript frameworks since it performs important tests.
1314
Just to explain: "npm run rebuild" must be used when the package-lock.json should be regenerated by
1415
npm install. "npm run rebuild-ci" can only be called when npm ci works and package.json and package-lock.json are in sync.
1516
7. if the npm command above reported "======> Please rerun the benchmark:" then the PR can be merged.
1617
* Check first if some file must be added to git and commit it. You can ignore all untracked files.
1718
* Merge the PR using merge commits as the merge strategy
1819
8. Delete the branch after merging
20+
9. Print the {list of framework-paths} from above
1921

2022
Rules:
2123
* Never push automatically to the remote

cli/zip.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,14 @@ function addFrameworksToZip(frameworkType, frameworkDir, frameworkName) {
7171
);
7272
break;
7373
}
74+
case "lui":
75+
case "lui-noeval": {
76+
addLocalFolderIfExists(
77+
`${frameworkDir}/src`,
78+
`${zipFrameworkPath}/src`
79+
);
80+
break;
81+
}
7482
case "stem": {
7583
addLocalFolderIfExists(
7684
`${frameworkDir}/node_modules/babel-polyfill/dist`,

0 commit comments

Comments
 (0)