Always create an empty prehandler list for convenient later mutation (#111)

Author: kibertoad

packages/amqp/lib/AbstractAmqpConsumerMonoSchema.ts

@@ -35,11 +35,7 @@ export abstract class AbstractAmqpConsumerMonoSchema<
 {
   private readonly messageSchema: ZodSchema<MessagePayloadType>
   private readonly schemaEither: Either<Error, ZodSchema<MessagePayloadType>>
-  private readonly prehandlers?: Prehandler<
-    MessagePayloadType,
-    ExecutionContext,
-    PrehandlerOutput
-  >[]
+  private readonly prehandlers: Prehandler<MessagePayloadType, ExecutionContext, PrehandlerOutput>[]
 
   constructor(
     dependencies: AMQPConsumerDependencies,
@@ -51,7 +47,7 @@ export abstract class AbstractAmqpConsumerMonoSchema<
   ) {
     super(dependencies, options)
 
-    this.prehandlers = options.prehandlers
+    this.prehandlers = options.prehandlers ?? []
     this.messageSchema = options.messageSchema
     this.schemaEither = {
       result: this.messageSchema,

packages/core/lib/queues/AbstractQueueService.ts

@@ -224,12 +224,10 @@ export abstract class AbstractQueueService<
   }
 
   protected processPrehandlersInternal(
-    prehandlers:
-      | Prehandler<MessagePayloadSchemas, ExecutionContext, PrehandlerOutput>[]
-      | undefined,
+    prehandlers: Prehandler<MessagePayloadSchemas, ExecutionContext, PrehandlerOutput>[],
     message: MessagePayloadSchemas,
   ) {
-    if (!prehandlers || prehandlers.length === 0) {
+    if (prehandlers.length === 0) {
       return Promise.resolve({} as PrehandlerOutput)
     }
 

packages/core/lib/queues/HandlerContainer.ts

@@ -83,7 +83,7 @@ export class MessageHandlerConfig<
     PrehandlerOutput,
     BarrierOutput
   >
-  public readonly prehandlers?: Prehandler<
+  public readonly prehandlers: Prehandler<
     MessagePayloadSchema,
     ExecutionContext,
     PrehandlerOutput
@@ -103,7 +103,7 @@ export class MessageHandlerConfig<
     this.handler = handler
     this.messageLogFormatter = options?.messageLogFormatter ?? defaultLogFormatter
     this.preHandlerBarrier = options?.preHandlerBarrier
-    this.prehandlers = options?.prehandlers
+    this.prehandlers = options?.prehandlers ?? []
   }
 }
 
@@ -116,6 +116,7 @@ export class MessageHandlerConfigBuilder<
     MessagePayloadSchemas,
     ExecutionContext,
     PrehandlerOutput,
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     any
   >[]
 

packages/sns/lib/sns/AbstractSnsSqsConsumerMonoSchema.ts

@@ -85,11 +85,7 @@ export abstract class AbstractSnsSqsConsumerMonoSchema<
   private readonly snsClient: SNSClient
   private readonly messageSchema: ZodSchema<MessagePayloadType>
   private readonly schemaEither: Either<Error, ZodSchema<MessagePayloadType>>
-  private readonly prehandlers?: Prehandler<
-    MessagePayloadType,
-    ExecutionContext,
-    PrehandlerOutput
-  >[]
+  private readonly prehandlers: Prehandler<MessagePayloadType, ExecutionContext, PrehandlerOutput>[]
 
   // @ts-ignore
   public topicArn: string
@@ -106,7 +102,7 @@ export abstract class AbstractSnsSqsConsumerMonoSchema<
 
     this.subscriptionConfig = options.subscriptionConfig
     this.snsClient = dependencies.snsClient
-    this.prehandlers = options.prehandlers
+    this.prehandlers = options.prehandlers ?? []
     this.messageSchema = options.messageSchema
     this.schemaEither = {
       result: this.messageSchema,

packages/sqs/lib/sqs/AbstractSqsConsumerMonoSchema.ts

@@ -93,16 +93,12 @@ export abstract class AbstractSqsConsumerMonoSchema<
 {
   private readonly messageSchema: ZodSchema<MessagePayloadType>
   private readonly schemaEither: Either<Error, ZodSchema<MessagePayloadType>>
-  private readonly prehandlers?: Prehandler<
-    MessagePayloadType,
-    ExecutionContext,
-    PrehandlerOutput
-  >[]
+  private readonly prehandlers: Prehandler<MessagePayloadType, ExecutionContext, PrehandlerOutput>[]
 
   protected constructor(dependencies: SQSConsumerDependencies, options: ConsumerOptionsType) {
     super(dependencies, options)
 
-    this.prehandlers = options.prehandlers
+    this.prehandlers = options.prehandlers ?? []
     this.messageSchema = options.messageSchema
     this.schemaEither = {
       result: this.messageSchema,