1.18.2: Broken leave messages, with default config

[TomLewis]

Are you using MySQL?

Yes

Are you using a proxy?

Yes - Velocity

"/version ChatControlRed" - plugin version

11.6.2

Optional: Error log

No response

ZIP of "/chc debug"

I just upgraded from 10.28.4 to 11.6.2 and the join/leave messages are throwing errors, even with the default freshly generated quit.rs

Steps to reproduce

Vanilla configs, someone leave the server on 1.18.2.

group default
message:
- <gray>{player} <white>left the server

[22:09:05] [Server thread/INFO]: [ChatControl] -------------------------------------------------------------------------------------------
[22:09:05] [Server thread/INFO]: [ChatControl]  Error parsing rule: JoinQuitKickMessage {
[22:09:05] [Server thread/INFO]: [ChatControl]   "Group": "default",
[22:09:05] [Server thread/INFO]: [ChatControl]   "Type": "quit",
[22:09:05] [Server thread/INFO]: [ChatControl]   "Messages": [
[22:09:05] [Server thread/INFO]: [ChatControl]     "{player} left the server"
[22:09:05] [Server thread/INFO]: [ChatControl]   ]
[22:09:05] [Server thread/INFO]: [ChatControl] }
[22:09:05] [Server thread/INFO]: [ChatControl]  Error: %error
[22:09:05] [Server thread/INFO]: [ChatControl] -------------------------------------------------------------------------------------------
[22:09:05] [Server thread/INFO]: net.kyori.adventure.text.minimessage.internal.parser.ParsingExceptionImpl: Legacy formatting codes have been detected in a MiniMessage string - this is unsupported behaviour. Please refer to the Adventure documentation (https://docs.adventure.kyori.net) for more information.
[22:09:05] [Server thread/INFO]:     PirateCraft left the game
[22:09:05] [Server thread/INFO]:     ^^

Ive been messing around with it, and every time its that error.
I even tried with no placeholders, same error, so its not me.

[22:15:19] [Server thread/INFO]: [ChatControl] -------------------------------------------------------------------------------------------
[22:15:19] [Server thread/INFO]: [ChatControl]  Error parsing rule: JoinQuitKickMessage {
[22:15:19] [Server thread/INFO]: [ChatControl]   "Group": "default",
[22:15:19] [Server thread/INFO]: [ChatControl]   "Type": "quit",
[22:15:19] [Server thread/INFO]: [ChatControl]   "Messages": [
[22:15:19] [Server thread/INFO]: [ChatControl]     "a player left the server"
[22:15:19] [Server thread/INFO]: [ChatControl]   ]
[22:15:19] [Server thread/INFO]: [ChatControl] }
[22:15:19] [Server thread/INFO]: [ChatControl]  Error: %error
[22:15:19] [Server thread/INFO]: [ChatControl] -------------------------------------------------------------------------------------------
[22:15:19] [Server thread/INFO]: net.kyori.adventure.text.minimessage.internal.parser.ParsingExceptionImpl: Legacy formatting codes have been detected in a MiniMessage string - this is unsupported behaviour. Please refer to the Adventure documentation (https://docs.adventure.kyori.net) for more information.
[22:15:19] [Server thread/INFO]:     PirateCraft left the game
[22:15:19] [Server thread/INFO]:     ^^

I even checked to make sure CMI wasnt trying to set a join/quit message, thats defo disabled.

It worked fine befroe I updated the plugin.

[devpedrobarbosa]

@TomLewis

If you're able to, please provide your debug.zip.

I'll be doing some tests on my end with Paper 1.18.2 and latest ChatControl version.

[TomLewis]

@devpedrobarbosa I just re-tested myself on a 1.18.2 local dev server with entirely freshly generated configs, I had to enable the join/quit in the settings.yml and rebooted, but its broken with default configs generated by the plugin.

Im going to try again with all plugins disabled on my local test server to see if its a conflict, ill report back then.

[TomLewis]

I can now confirm default configs no other plugins its also broken on 1.18.2. So its not a conflict, its not my configs, its the fault of ChatControl.

I will for now have to use CMI to do login/exit messages just to get that functionality back....

[TomLewis]

Think I may have an idea.

Does your velocity control now block all join messages? I have it disabled but I recently had an enormous headache and wasted so much of my time figuring out that /me override in the proxy and for some insane reason have it default to on, so then these commands silently fail on all servers with no log or anything

But after I figured this out, rebooted the proxy it was working again.

Is the join the same? Did you stop joining messages be triggered on the server's if you use a proxy? I just can't figure it out.

Nothing is working for join, quit, new user's none of the stats based things like 100 joins, I've had to migrate all of this to CMI.

[devpedrobarbosa]

It's working fine for me.
My setup:
Latest Velocity Build + Latest VelocityControl
Paper 1.18.2 + Latest ChatControl

Have you updated your VelocityControl? It is also recommended to use the latest Paper versions (working fine as well).

If you're able to, please provide your debug.zip so that I can try to narrow this down.

Thanks and sorry for the delay.

[devpedrobarbosa]

@TomLewis

Reviewing the actual error, I've noticed it's being caused by "legacy color codes inside MiniMessage string".

I don't see where our plugin would be leaving legacy color codes inside MiniMessage strings, but I've seen this happen before due to inconsistencies between Adventure versions. This could be either due to third party plugins or outdated/unofficial Paper builds/forks.

Your debug.zip will help me understand this perspective better.

Thanks.

[kangarko]

@TomLewis I am sorry for the late response from my end, can you please post the entire stack trace? There must be a more detailed error log. Also check errors.log

[devpedrobarbosa]

@TomLewis

Are you still experiencing this issue?

[TomLewis]

Sorry I haven't had time to go further.
Definitely still having this issue, I've also encountered more issues with game events just not working at all, for example now PvP managers chat message no longer fire when someone is killed in PvP after I updated to this version of chat control.

But normal death messages from chat control are still working, just entirely stopping the PvP manager ones.

I have the latest velocity control too yes. It's just very odd.

The error you are seeing is most likely the vanilla log in and out messages having the old color code from 1.18 and below still, I presume this event gets cancelled and sent instead from chat control or should..

There's nothing special with the setup as I'm using default configs, entirely fresh with no plugins for testing too.

I'll try and re test tonight if I get some time and look at the errors log, forgot to check this

[devpedrobarbosa]

@TomLewis

Unfortunatelly I haven't been able to reproduce this yet. At least not with Paper 1.18.2 and the only plugin being the latest ChatControl as you mentioned.

VelocityControl cannot be causing this issue. For me, it looks like it's being caused by a third party plugin.

I understand that there could be nothing specific in your ChatControl setup that could be causing this, but your debug.zip provides more precious detail such as specific software versions, other plugins installed, etc.

Please send it so that I can investigate further.

Thanks for reaching back!

[devpedrobarbosa]

@TomLewis

I'll be closing this issue since I was not able to reproduce at all with the steps you provided.

Again, this is most likely being caused by a third party plugin.

Thanks once again for reaching out.