Handle lack of trailing slashes in hub URLs

yuvipanda · yuvipanda · commit ebe3998a511d · 2021-04-23T21:07:39.000+05:30
Without this, if your hub url was something like https://myhub.com/jupyter, your nbgitpuller URL will be something like https://myhub.com/jupyterhub/user-redirect... instead of https://myhub.com/jupyter/hub/user-redirect...
diff --git a/docs/_static/link_gen/link.js b/docs/_static/link_gen/link.js
@@ -14,6 +14,9 @@ function generateRegularUrl(hubUrl, urlPath, repoUrl, branch) {
         url.searchParams.set('branch', branch);
     }
 
+    if (!url.pathname.endsWith('/')) {
+        url.pathname += '/'
+    }
     url.pathname += 'hub/user-redirect/git-pull';
 
     return url.toString();

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,9 @@ function generateRegularUrl(hubUrl, urlPath, repoUrl, branch) {`
`14`	`14`	`url.searchParams.set('branch', branch);`
`15`	`15`	`}`
`16`	`16`
	`17`	`+ if (!url.pathname.endsWith('/')) {`
	`18`	`+ url.pathname += '/'`
	`19`	`+ }`
`17`	`20`	`url.pathname += 'hub/user-redirect/git-pull';`
`18`	`21`
`19`	`22`	`return url.toString();`