Merge pull request #347 from minrk/403-on-fail

consideRatio · web-flow · commit 79784e0152fb · 2024-03-29T10:28:02.000+01:00
403 on failed auth for EventStream
diff --git a/nbgitpuller/handlers.py b/nbgitpuller/handlers.py
@@ -29,6 +29,12 @@ def __init__(self, *args, **kwargs):
         if 'git_lock' not in self.settings:
             self.settings['git_lock'] = locks.Lock()
 
+    def get_login_url(self):
+        # raise on failed auth, not redirect
+        # can't redirect EventStream to login
+        # same as Jupyter's APIHandler
+        raise web.HTTPError(403)
+
     @property
     def git_lock(self):
         return self.settings['git_lock']
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -136,7 +136,7 @@ def test_clone_auth(jupyterdir, jupyter_server):
         }
         r = request_api(params)
         # no token, redirect to login
-        assert r.code == 302
+        assert r.code == 403
 
 
 def test_clone_targetpath(jupyterdir, jupyter_server):

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ def test_clone_auth(jupyterdir, jupyter_server):`
`136`	`136`	`}`
`137`	`137`	`r = request_api(params)`
`138`	`138`	`# no token, redirect to login`
`139`		`- assert r.code == 302`
	`139`	`+ assert r.code == 403`
`140`	`140`
`141`	`141`
`142`	`142`	`def test_clone_targetpath(jupyterdir, jupyter_server):`