Skip to content

Commit ecc4343

Browse files
authored
Merge pull request #51 from adsche/binary-websocket-proxy
Make sure binary messages are proxied correctly (fixes #50)
2 parents 9da7ac7 + 9dbd162 commit ecc4343

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

nbserverproxy/handlers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def message_cb(message):
130130
if message is None:
131131
self.close()
132132
else:
133-
self.write_message(message, binary=type(message) is bytes)
133+
self.write_message(message, binary=isinstance(message, bytes))
134134

135135
def ping_cb(data):
136136
"""
@@ -160,7 +160,7 @@ def on_message(self, message):
160160
"""
161161
self._record_activity()
162162
if hasattr(self, 'ws'):
163-
self.ws.write_message(message)
163+
self.ws.write_message(message, binary=isinstance(message, bytes))
164164

165165
def on_ping(self, data):
166166
"""

0 commit comments

Comments
 (0)