Add org.junit.openrewrite.SanityCheck
#5193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Pankraz76
commented
Dec 2, 2025
gradle/plugins/common/src/main/kotlin/junitbuild.rewrite-conventions.gradle.kts
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
2 times, most recently
from
2630106 to
bc5d7ff
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
bc5d7ff to
cc25b56
Compare
Pankraz76
commented
Dec 2, 2025
Pankraz76
commented
Dec 2, 2025
jupiter-tests/src/test/java/org/junit/jupiter/engine/TestClassInheritanceTests.java
Outdated
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
2 times, most recently
from
a32c1ec to
8429a08
Compare
3 tasks
Contributor
Author
|
discovering the specialties took more than 2h to collect. Of course junit worth every effort. BUILD SUCCESSFUL in 3m 19s making this fully reprod. is first premise: 
|
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
2 times, most recently
from
df3ca59 to
7b1dced
Compare
Pankraz76
changed the title
junit5.CleanupAssertionsJupiterBestPractices
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
7b1dced to
90e9799
Compare
Pankraz76
commented
Dec 4, 2025
...rm-tooling-support-tests/src/test/java/platform/tooling/support/tests/ToolProviderTests.java
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
90e9799 to
fd77fdf
Compare
Pankraz76
changed the title
JupiterBestPracticesJupiterBestPractices
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
fd77fdf to
c0dc000
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
c0dc000 to
2ef0570
Compare
Pankraz76
changed the title
JupiterBestPracticesorg.junit.openrewrite.SanityCheck
✅ All tests passed ✅🏷️ Commit: 4c1138f |
Pankraz76
changed the title
org.junit.openrewrite.SanityCheckorg.junit.openrewrite.SanityCheck 🕊
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
5ead7f7 to
b33ddf8
Compare
Pankraz76
commented
Dec 5, 2025
| tasks.check { | ||
| dependsOn(tasks.withType<Checkstyle>()) | ||
| } | ||
| //tasks.check { // assuming spotless does the job already, checkstyle is first dedicated redundancy layer. |
Contributor
Author
There was a problem hiding this comment.
assuming spotless does the job already, considering checkstyle as first dedicated redundancy layer.
Pankraz76
commented
Dec 5, 2025
| } | ||
|
|
||
| tasks.check { | ||
| dependsOn(archUnit) |
Contributor
Author
There was a problem hiding this comment.
considering this hopefully so rare, running this only "once" in CI.
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
b33ddf8 to
a155d8b
Compare
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
a155d8b to
9da952e
Compare
sbrannen
changed the title
org.junit.openrewrite.SanityCheck 🕊org.junit.openrewrite.SanityCheck
enabler for: - https://docs.openrewrite.org/recipes/java/testing/junit/jupiterbestpractices Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
fix-JUnit5BestPractices
branch
from
9da952e to
4c1138f
Compare
This was referenced Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
org.junit.openrewrite.SanityCheckenabler for:
related to:
error-prone.picnic.tech/bugpatterns/NonStaticImport#5191SanityCheckfeaturingCommonStaticAnalysisdiffplug/spotless#2651UpgradeToJava17diffplug/spotless#2636I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations