[junit] add JupiterBestPractices

- https://docs.openrewrite.org/recipes/java/testing/junit/jupiterbestpractices

Signed-off-by: Vincent Potucek <vpotucek@me.com>

...

> Task :platform-tests:rewriteRun
There were problems parsing platform-tests/platform-tests.gradle.kts
All sources parsed, running active recipes: org.junit.openrewrite.SanityCheck
Changes have been made to platform-tests/src/test/java/org/junit/platform/reporting/legacy/xml/LegacyXmlReportGeneratingListenerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to platform-tests/src/test/java/org/junit/platform/reporting/open/xml/OpenTestReportGeneratingListenerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/reporting/open/xml/JUnitContributorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/core/DefaultLauncherTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.AssertThrowsOnLastStatement
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/core/LauncherFactoryTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/core/StreamInterceptorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/core/HierarchicalOutputDirectoryCreatorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/core/ExecutionListenerAdapterTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/core/ListenerRegistryTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/core/InternalTestPlanTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/listeners/UniqueIdTrackingListenerIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/listeners/SummaryGenerationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/listeners/discovery/LoggingLauncherDiscoveryListenerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/listeners/LoggingListenerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/launcher/listeners/session/CompositeLauncherSessionListenerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/commons/util/ReflectionUtilsWithGenericTypeHierarchiesTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/commons/util/pkg1/SuperclassWithStaticPackagePrivateBeforeMethod.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/commons/util/DefaultClasspathScannerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to platform-tests/src/test/java/org/junit/platform/commons/annotation/TestableAnnotationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to platform-tests/src/test/java/org/junit/platform/commons/function/TryTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/commons/support/ResourceInteroperabilityTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/testkit/engine/NestedContainerEventConditionTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/DiscoveryIssueTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/support/hierarchical/ParallelExecutionIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/support/hierarchical/ForkJoinDeadLockTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/support/hierarchical/SameThreadExecutionIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/support/discovery/EngineDiscoveryRequestResolverTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/support/descriptor/ClassSourceTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/support/store/NamespaceTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/TestTagTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
Changes have been made to platform-tests/src/test/java/org/junit/platform/StackTracePruningTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport: {methodPattern=org.junit.jupiter.api.Assertions *(..)}
Changes have been made to platform-tests/src/test/java/org/junit/platform/console/output/TestFeedPrintingListenerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to platform-tests/src/test/java/org/junit/platform/console/ConsoleLauncherIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to platform-tests/src/jmh/java/org/junit/jupiter/jmh/AssertionBenchmarks.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport: {methodPattern=org.junit.jupiter.api.Assertions *(..)}
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
Please review and commit the results.
Estimate time saved: 1h 58m

> Task :jupiter-tests:rewriteRun
Validating active recipes
Scanning sources in project :jupiter-tests
Using active styles []
There were problems parsing some source files, run with --info to see full stack traces
There were problems parsing jupiter-tests/src/test/java/org/junit/jupiter/params/provider/MethodArgumentsProviderTests.java
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/params/converter/TypedArgumentConverterKotlinTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/params/aggregator/DisplayNameTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/params/aggregator/ArgumentsAccessorKotlinTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/params/ParameterizedTestKotlinSequenceIntegrationTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/params/ParameterizedInvocationNameFormatterIntegrationTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/params/ParameterizedClassKotlinIntegrationTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/api/kotlin/KotlinAssertionsTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/api/kotlin/KotlinFailAssertionsTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/api/kotlin/KotlinDynamicTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/api/kotlin/KotlinAssertTimeoutAssertionsTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/api/kotlin/KotlinSuspendFunctionsTests.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/engine/kotlin/InstancePerMethodKotlinTestCase.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/engine/kotlin/KotlinInterfaceTestCase.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/engine/kotlin/KotlinInterfaceImplementationTestCase.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/engine/kotlin/KotlinDefaultImplsTestCase.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/engine/kotlin/ArbitraryNamingKotlinTestCase.kt
There were problems parsing jupiter-tests/src/test/kotlin/org/junit/jupiter/engine/kotlin/InstancePerClassKotlinTestCase.kt
There were problems parsing jupiter-tests/jupiter-tests.gradle.kts
All sources parsed, running active recipes: org.junit.openrewrite.SanityCheck
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/migrationsupport/rules/AbstractTestRuleAdapterTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/migrationsupport/rules/VerifierSupportForMixedMethodAndFieldRulesTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/migrationsupport/rules/WrongExtendWithForVerifierMethodTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/migrationsupport/rules/WrongExtendWithForVerifierFieldTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/params/ParameterizedTestIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CsvSourceToValueSource
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/params/support/AnnotationConsumerInitializerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CsvSourceToValueSource
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
        org.openrewrite.java.testing.junit5.AddParameterizedTestAnnotation
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/params/ParameterizedClassIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/AssertNotSameAssertionsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/parallel/ResourceLockAnnotationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/extension/ExecutableInvokerIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/extension/CloseableResourceIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/DynamicTestTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport: {methodPattern=org.junit.jupiter.api.Assertions *(..)}
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/AssertFalseAssertionsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes
            org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes$WithMessageRecipe
            org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes$WithoutMessageRecipe
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/subpackage/SubclassedAssertionsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes
            org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes$WithoutMessageRecipe
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfIntegrationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfConditionTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/condition/JRETests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfConditionClassLoaderTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionClassLoaderTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/DisplayNameGenerationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/api/AssertTrueAssertionsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes
            org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes$WithMessageRecipe
            org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes$WithoutMessageRecipe
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/FailedAssumptionsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/ClassTemplateInvocationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TestInstanceFactoryTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/RepeatedTestTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/LifecycleMethodExecutionExceptionHandlerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/BeforeAndAfterAllTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/CloseablePathTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TestInstancePostProcessorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TempDirectoryCleanupTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TempDirectoryTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TestInstancePreDestroyCallbackUtilityMethodTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TestInstancePostProcessorAndPreDestroyCallbackTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/BeforeAndAfterTestExecutionCallbackTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/ParameterResolverTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TimeoutExtensionTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/InvocationInterceptorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/ExecutionConditionTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TestInstancePreDestroyCallbackTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/BeforeAndAfterEachTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TestExecutionExceptionHandlerTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/ExtensionRegistrationViaParametersAndFieldsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/PreInterruptCallbackTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/NestedWithInheritanceTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/bridge/ChildWithBridgeMethods.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/bridge/ChildWithoutBridgeMethods.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/bridge/AbstractNonGenericTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport: {methodPattern=org.junit.jupiter.api.Assertions *(..)}
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/bridge/PackagePrivateParent.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/NestedWithSeparateInheritanceTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/ExecutionCancellationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/MultipleTestableAnnotationsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.junit5.RemoveDuplicateTestTemplates
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/discovery/predicates/IsTestMethodTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
        org.openrewrite.java.testing.cleanup.TestMethodsShouldBeVoid
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/discovery/predicates/IsTestTemplateMethodTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.TestMethodsShouldBeVoid
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/discovery/DiscoveryTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
        org.openrewrite.java.testing.cleanup.TestMethodsShouldBeVoid
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/discovery/DiscoverySelectorResolverTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/ExceptionHandlingTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport: {methodPattern=org.junit.jupiter.api.Assertions *(..)}
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
        org.openrewrite.java.testing.cleanup.SimplifyTestThrows
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/TestClassInheritanceTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/StandardTestClassTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/execution/ParameterResolutionUtilsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.AssertThrowsOnLastStatement
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/SealedClassTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/TestTemplateInvocationTestDescriptorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/ExtensionContextTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/JupiterTestDescriptorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/TestTemplateTestDescriptorTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/subpackage/ClassWithStaticInnerTestCases.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/subpackage/Class2WithTestCases.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/subpackage/Class1WithTestCases.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/NamespaceTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/LifecycleMethodUtilsTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.LifecycleNonPrivate
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/TestTemplateInvocationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.RemoveTestPrefix
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/NestedTestClassesTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport: {methodPattern=org.junit.jupiter.api.Assertions *(..)}
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/LifecycleMethodOverridingTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/JupiterTestEngineTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/RecordTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/TestInstanceLifecycleConfigurationTests.java by:
    org.openrewrite.java.testing.junit.JupiterBestPractices
        org.openrewrite.java.testing.junit5.CleanupAssertions
            org.openrewrite.java.testing.cleanup.AssertionsArgumentOrder
Please review and commit the results.
Estimate time saved: 4h 25m

Author: Vincent Potucek

.github/workflows/sanity-check.yml

@@ -1,5 +1,4 @@
-name: Rewrite ♻️
-
+name: ✅Rewrite
 on:
   push:
     branches:
@@ -10,22 +9,19 @@ on:
   pull_request:
     paths:
       - '.github/**'
-
 permissions: {}
-
 jobs:
   sanity-check:
-    name: Sanity Check 🕊
+    name: 🕊Sanity Check
     runs-on: ubuntu-latest
     permissions:
       security-events: write
     steps:
-      - name: Checkout repository
+      - name: 📥Checkout Repository
         uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
         with:
           persist-credentials: false
-
-      - name: rewriteDryRun
+      - name: 🌀Rewrite Dry Run
         uses: ./.github/actions/run-gradle
         with:
           encryptionKey: ${{ secrets.GRADLE_ENCRYPTION_KEY }}

gradle/config/rewrite.yml

@@ -9,9 +9,7 @@ tags:
   - static-analysis
   - cleanup
 recipeList:
-  - org.openrewrite.java.format.NormalizeLineBreaks
-  - org.openrewrite.java.format.RemoveTrailingWhitespace
-  - org.openrewrite.java.testing.junit5.CleanupAssertions
-  # blank out breaking, consider individual fix.
-  # - org.openrewrite.java.testing.junit5.JUnit5BestPractices
+  - org.openrewrite.java.testing.junit.JupiterBestPractices
+  # - org.openrewrite.staticanalysis.CodeCleanup
+  # - org.openrewrite.staticanalysis.CommonStaticAnalysis
 ---

gradle/plugins/common/src/main/kotlin/junitbuild.rewrite-conventions.gradle.kts

@@ -2,17 +2,57 @@ plugins {
 	id("org.openrewrite.rewrite")
 }
 
+dependencies {
+	rewrite("org.openrewrite.recipe:rewrite-static-analysis:2.22.0")
+	rewrite("org.openrewrite.recipe:rewrite-testing-frameworks:3.22.0")
+}
+
 rewrite {
 	activeRecipe("org.junit.openrewrite.SanityCheck")
 	configFile = project.getRootProject().file("gradle/config/rewrite.yml")
-	// blank out breaking, consider individual fix.
-	exclusion("**AssertEqualsAssertionsTests.java")
-	exclusion("**AssertIterableEqualsAssertionsTests.java")
-	exclusion("**AssertSameAssertionsTests.java")
+	exclusion(
+		"**AggregatorIntegrationTests.java",
+		"**AnnotationConsumerInitializerTests.java",
+		"**Assert**AssertionsTests.java", // trivial import fix.
+		"**BeforeAndAfterSuiteTests.java",
+		"**BridgeMethods.java",
+		"**DiscoverySelectorResolverTests.java",
+		"**DiscoveryTests.java",
+		"**DisplayNameGenerationTests.java",
+		"**DynamicNodeGenerationTests.java",
+		"**DynamicTestTests.java",
+		"**ExceptionHandlingTests.java",
+		"**ExecutionCancellationTests.java",
+		"**ExtensionRegistrationViaParametersAndFieldsTests.java",
+		"**InvocationInterceptorTests.java",
+		"**IsTestMethodTests.java",
+		"**IsTestTemplateMethodTests.java",
+		"**JupiterTestDescriptorTests.java",
+		"**LifecycleMethodUtilsTests.java",
+		"**MultipleTestableAnnotationsTests.java",
+		"**NestedContainerEventConditionTests.java",
+		"**ParallelExecutionIntegrationTests.java",
+		"**ParameterResolverTests.java",
+		"**ParameterizedTestIntegrationTests.java",
+		"**RepeatedTestTests.java",
+		"**StaticPackagePrivateBeforeMethod.java",
+		"**SubclassedAssertionsTests.java",
+		"**TempDirectoryCleanupTests.java",
+		"**TestCase.java",
+		"**TestCases.java",
+		"**TestExecutionExceptionHandlerTests.java",
+		"**TestInstanceFactoryTests.java",
+		"**TestTemplateInvocationTestDescriptorTests.java",
+		"**TestTemplateInvocationTests.java",
+		"**TestTemplateTestDescriptorTests.java",
+		"**TestWatcherTests.java",
+		"**TimeoutExtensionTests.java",
+		"**UniqueIdTrackingListenerIntegrationTests.java",
+		"**WorkerThreadPoolHierarchicalTestExecutorServiceTests.java",
+		"**documentation/src/test/java/example**",
+		"**org/junit/jupiter/engine/bridge**",
+		"**testFixtures/java/org/junit/vintage/engine/samples**",
+	)
 	setExportDatatables(true)
 	setFailOnDryRunResults(true)
 }
-
-dependencies {
-	rewrite("org.openrewrite.recipe:rewrite-testing-frameworks:3.22.0")
-}

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionClassLoaderTests.java

@@ -29,7 +29,7 @@
  *
  * @since 5.10
  */
-public class DisabledIfConditionClassLoaderTests {
+class DisabledIfConditionClassLoaderTests {
 
 	@Test
 	// No need to introduce a "disabled" version of this test, since it would simply be the

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class DisabledIfConditionTests extends AbstractExecutionConditionTests {
+class DisabledIfConditionTests extends AbstractExecutionConditionTests {
 
 	@Override
 	protected ExecutionCondition getExecutionCondition() {

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfIntegrationTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class DisabledIfIntegrationTests {
+class DisabledIfIntegrationTests {
 
 	@Test
 	@Disabled("Only used in a unit test via reflection")

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfConditionClassLoaderTests.java

@@ -29,7 +29,7 @@
  *
  * @since 5.10
  */
-public class EnabledIfConditionClassLoaderTests {
+class EnabledIfConditionClassLoaderTests {
 
 	@Test
 	// No need to introduce a "disabled" version of this test, since it would simply be the

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfConditionTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class EnabledIfConditionTests extends AbstractExecutionConditionTests {
+class EnabledIfConditionTests extends AbstractExecutionConditionTests {
 
 	@Override
 	protected ExecutionCondition getExecutionCondition() {

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfIntegrationTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class EnabledIfIntegrationTests {
+class EnabledIfIntegrationTests {
 
 	@Test
 	@Disabled("Only used in a unit test via reflection")

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/JRETests.java

@@ -29,7 +29,7 @@
  *
  * @since 5.7
  */
-public class JRETests {
+class JRETests {
 
 	private static final JRE CURRENT_JRE = JRE.currentJre();