[junit] add JupiterBestPractices

- https://docs.openrewrite.org/recipes/java/testing/junit/jupiterbestpractices

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Author: Vincent Potucek

.github/workflows/sanity-check.yml

@@ -1,5 +1,4 @@
-name: Rewrite ♻️
-
+name: ✅Rewrite
 on:
   push:
     branches:
@@ -10,22 +9,19 @@ on:
   pull_request:
     paths:
       - '.github/**'
-
 permissions: {}
-
 jobs:
   sanity-check:
-    name: Sanity Check 🕊
+    name: 🕊Sanity Check
     runs-on: ubuntu-latest
     permissions:
       security-events: write
     steps:
-      - name: Checkout repository
+      - name: 📥Checkout Repository
         uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
         with:
           persist-credentials: false
-
-      - name: rewriteDryRun
+      - name: 🌀Rewrite Dry Run
         uses: ./.github/actions/run-gradle
         with:
           encryptionKey: ${{ secrets.GRADLE_ENCRYPTION_KEY }}

gradle/config/rewrite.yml

@@ -9,9 +9,7 @@ tags:
   - static-analysis
   - cleanup
 recipeList:
-  - org.openrewrite.java.format.NormalizeLineBreaks
-  - org.openrewrite.java.format.RemoveTrailingWhitespace
-  - org.openrewrite.java.testing.junit5.CleanupAssertions
-  # blank out breaking, consider individual fix.
-  # - org.openrewrite.java.testing.junit5.JUnit5BestPractices
+  - org.openrewrite.java.testing.junit.JupiterBestPractices
+  # - org.openrewrite.staticanalysis.CodeCleanup
+  # - org.openrewrite.staticanalysis.CommonStaticAnalysis
 ---

gradle/plugins/common/src/main/kotlin/junitbuild.rewrite-conventions.gradle.kts

@@ -2,17 +2,57 @@ plugins {
 	id("org.openrewrite.rewrite")
 }
 
+dependencies {
+	rewrite("org.openrewrite.recipe:rewrite-static-analysis:2.22.0")
+	rewrite("org.openrewrite.recipe:rewrite-testing-frameworks:3.22.0")
+}
+
 rewrite {
 	activeRecipe("org.junit.openrewrite.SanityCheck")
 	configFile = project.getRootProject().file("gradle/config/rewrite.yml")
-	// blank out breaking, consider individual fix.
-	exclusion("**AssertEqualsAssertionsTests.java")
-	exclusion("**AssertIterableEqualsAssertionsTests.java")
-	exclusion("**AssertSameAssertionsTests.java")
+	exclusion(
+		"**AggregatorIntegrationTests.java",
+		"**AnnotationConsumerInitializerTests.java",
+		"**Assert**AssertionsTests.java", // trivial import fix.
+		"**BeforeAndAfterSuiteTests.java",
+		"**BridgeMethods.java",
+		"**DiscoverySelectorResolverTests.java",
+		"**DiscoveryTests.java",
+		"**DisplayNameGenerationTests.java",
+		"**DynamicNodeGenerationTests.java",
+		"**DynamicTestTests.java",
+		"**ExceptionHandlingTests.java",
+		"**ExecutionCancellationTests.java",
+		"**ExtensionRegistrationViaParametersAndFieldsTests.java",
+		"**InvocationInterceptorTests.java",
+		"**IsTestMethodTests.java",
+		"**IsTestTemplateMethodTests.java",
+		"**JupiterTestDescriptorTests.java",
+		"**LifecycleMethodUtilsTests.java",
+		"**MultipleTestableAnnotationsTests.java",
+		"**NestedContainerEventConditionTests.java",
+		"**ParallelExecutionIntegrationTests.java",
+		"**ParameterResolverTests.java",
+		"**ParameterizedTestIntegrationTests.java",
+		"**RepeatedTestTests.java",
+		"**StaticPackagePrivateBeforeMethod.java",
+		"**SubclassedAssertionsTests.java",
+		"**TempDirectoryCleanupTests.java",
+		"**TestCase.java",
+		"**TestCases.java",
+		"**TestExecutionExceptionHandlerTests.java",
+		"**TestInstanceFactoryTests.java",
+		"**TestTemplateInvocationTestDescriptorTests.java",
+		"**TestTemplateInvocationTests.java",
+		"**TestTemplateTestDescriptorTests.java",
+		"**TestWatcherTests.java",
+		"**TimeoutExtensionTests.java",
+		"**UniqueIdTrackingListenerIntegrationTests.java",
+		"**WorkerThreadPoolHierarchicalTestExecutorServiceTests.java",
+		"**documentation/src/test/java/example**",
+		"**org/junit/jupiter/engine/bridge**",
+		"**testFixtures/java/org/junit/vintage/engine/samples**",
+	)
 	setExportDatatables(true)
 	setFailOnDryRunResults(true)
 }
-
-dependencies {
-	rewrite("org.openrewrite.recipe:rewrite-testing-frameworks:3.22.0")
-}

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionClassLoaderTests.java

@@ -29,7 +29,7 @@
  *
  * @since 5.10
  */
-public class DisabledIfConditionClassLoaderTests {
+class DisabledIfConditionClassLoaderTests {
 
 	@Test
 	// No need to introduce a "disabled" version of this test, since it would simply be the

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class DisabledIfConditionTests extends AbstractExecutionConditionTests {
+class DisabledIfConditionTests extends AbstractExecutionConditionTests {
 
 	@Override
 	protected ExecutionCondition getExecutionCondition() {

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfIntegrationTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class DisabledIfIntegrationTests {
+class DisabledIfIntegrationTests {
 
 	@Test
 	@Disabled("Only used in a unit test via reflection")

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfConditionClassLoaderTests.java

@@ -29,7 +29,7 @@
  *
  * @since 5.10
  */
-public class EnabledIfConditionClassLoaderTests {
+class EnabledIfConditionClassLoaderTests {
 
 	@Test
 	// No need to introduce a "disabled" version of this test, since it would simply be the

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfConditionTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class EnabledIfConditionTests extends AbstractExecutionConditionTests {
+class EnabledIfConditionTests extends AbstractExecutionConditionTests {
 
 	@Override
 	protected ExecutionCondition getExecutionCondition() {

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/EnabledIfIntegrationTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class EnabledIfIntegrationTests {
+class EnabledIfIntegrationTests {
 
 	@Test
 	@Disabled("Only used in a unit test via reflection")

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/JRETests.java

@@ -29,7 +29,7 @@
  *
  * @since 5.7
  */
-public class JRETests {
+class JRETests {
 
 	private static final JRE CURRENT_JRE = JRE.currentJre();