[rewrite] add JupiterBestPractices

- https://docs.openrewrite.org/recipes/java/testing/junit/jupiterbestpractices

- https://docs.openrewrite.org/recipes/staticanalysis/commonstaticanalysis

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Author: Vincent Potucek

.github/workflows/rewrite.yml

@@ -0,0 +1,28 @@
+name: Rewrite ✅
+on:
+  push:
+    branches:
+      - main
+      - 'releases/**'
+    paths:
+      - '.github/**'
+  pull_request:
+    paths:
+      - '.github/**'
+permissions: {}
+jobs:
+  rewrite:
+    name: Sanity Check 🕊
+    runs-on: ubuntu-latest
+    permissions:
+      security-events: write
+    steps:
+      - name: Checkout Repository 📥
+        uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
+        with:
+          persist-credentials: false
+      - name: Dry Run 🧮
+        uses: ./.github/actions/run-gradle
+        with:
+          encryptionKey: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
+          arguments: rewriteDryRun -Dorg.gradle.jvmargs=-Xmx2G

gradle/config/rewrite.yml

@@ -0,0 +1,14 @@
+---
+type: specs.openrewrite.org/v1beta/recipe
+name: org.junit.openrewrite.SanityCheck
+displayName: Apply all Java & Gradle best practices
+description: Comprehensive code quality recipe combining modernization, security, and best practices.
+tags:
+  - java
+  - gradle
+  - static-analysis
+  - cleanup
+recipeList:
+  - org.openrewrite.java.testing.junit.JupiterBestPractices
+  # - org.openrewrite.staticanalysis.CommonStaticAnalysis
+---

gradle/libs.versions.toml

@@ -101,6 +101,7 @@ commonCustomUserData = { id = "com.gradle.common-custom-user-data-gradle-plugin"
 develocity = { id = "com.gradle.develocity", version = "4.2.2" }
 download = { id = "de.undercouch.download", version = "5.6.0" }
 errorProne = { id = "net.ltgt.errorprone", version = "4.3.0" }
+rewrite = { id = "org.openrewrite.rewrite", version = "7.21.0" }
 foojayResolver = { id = "org.gradle.toolchains.foojay-resolver", version = "1.0.0" }
 gitPublish = { id = "org.ajoberstar.git-publish", version = "5.1.3" }
 jmh = { id = "me.champeau.jmh", version = "0.7.3" }

gradle/plugins/common/build.gradle.kts

@@ -7,16 +7,17 @@ plugins {
 
 dependencies {
 	implementation("junitbuild.base:dsl-extensions")
-	implementation(projects.buildParameters)
 	implementation(projects.backwardCompatibility)
-	implementation(libs.plugins.kotlin.markerCoordinates)
+	implementation(projects.buildParameters)
 	implementation(libs.plugins.bnd.markerCoordinates)
 	implementation(libs.plugins.commonCustomUserData.markerCoordinates)
 	implementation(libs.plugins.develocity.markerCoordinates)
 	implementation(libs.plugins.errorProne.markerCoordinates)
 	implementation(libs.plugins.foojayResolver.markerCoordinates)
 	implementation(libs.plugins.jmh.markerCoordinates)
+	implementation(libs.plugins.kotlin.markerCoordinates)
 	implementation(libs.plugins.nullaway.markerCoordinates)
+	implementation(libs.plugins.rewrite.markerCoordinates)
 	implementation(libs.plugins.shadow.markerCoordinates)
 	implementation(libs.plugins.spotless.markerCoordinates)
 }

gradle/plugins/common/src/main/kotlin/junitbuild.java-errorprone-conventions.gradle.kts

@@ -45,6 +45,7 @@ tasks.withType<JavaCompile>().configureEach {
 			error(
 				"CanonicalAnnotationSyntax",
 				"IsInstanceLambdaUsage",
+				"TryWithResourcesVariable",
 				"PackageLocation",
 				"RedundantStringConversion",
 				"RedundantStringEscape",

gradle/plugins/common/src/main/kotlin/junitbuild.java-library-conventions.gradle.kts

@@ -9,6 +9,7 @@ plugins {
 	id("junitbuild.eclipse-conventions")
 	id("junitbuild.jacoco-java-conventions")
 	id("junitbuild.java-errorprone-conventions")
+	id("junitbuild.rewrite-conventions")
 }
 
 val mavenizedProjects: List<Project> by rootProject.extra

gradle/plugins/common/src/main/kotlin/junitbuild.rewrite-conventions.gradle.kts

@@ -0,0 +1,68 @@
+plugins {
+	id("org.openrewrite.rewrite")
+}
+
+dependencies {
+	rewrite("org.openrewrite.recipe:rewrite-static-analysis:2.22.0")
+	rewrite("org.openrewrite.recipe:rewrite-testing-frameworks:3.22.0")
+}
+
+rewrite {
+	activeRecipe("org.junit.openrewrite.SanityCheck")
+	configFile = project.getRootProject().file("gradle/config/rewrite.yml")
+	exclusion(
+		// CommonStaticAnalysis: scope issue; CONSTRUCTOR_NOW_PROTECTED
+		"**/params/aggregator/**",
+		"**/params/converter/**",
+		"**/params/provider/**",
+		"**AggregatorIntegrationTests.java",
+		"**AnnotationConsumerInitializerTests.java",
+		"**HierarchicalTestEngine.java",
+		"**TypeBasedParameterResolver.java",
+		// JupiterBestPractices: class scope issue;
+		"**Assert**AssertionsTests.java", // trivial import fix.
+		"**BeforeAndAfterSuiteTests.java",
+		"**BridgeMethods.java",
+		"**CsvArgumentsProvider.java",
+		"**DefaultArgumentsAccessor.java",
+		"**DiscoverySelectorResolverTests.java",
+		"**DiscoveryTests.java",
+		"**DisplayNameGenerationTests.java",
+		"**DynamicNodeGenerationTests.java",
+		"**DynamicTestTests.java",
+		"**ExceptionHandlingTests.java",
+		"**ExecutionCancellationTests.java",
+		"**ExtensionRegistrationViaParametersAndFieldsTests.java",
+		"**InvocationInterceptorTests.java",
+		"**IsTestMethodTests.java",
+		"**IsTestTemplateMethodTests.java",
+		"**JupiterTestDescriptorTests.java",
+		"**LifecycleMethodUtilsTests.java",
+		"**MultipleTestableAnnotationsTests.java",
+		"**NestedContainerEventConditionTests.java",
+		"**ParallelExecutionIntegrationTests.java",
+		"**ParameterResolverTests.java",
+		"**ParameterizedTestIntegrationTests.java",
+		"**RepeatedTestTests.java",
+		"**StaticPackagePrivateBeforeMethod.java",
+		"**SubclassedAssertionsTests.java",
+		"**TempDirectoryCleanupTests.java",
+		"**TestCase.java",
+		"**TestCases.java",
+		"**TestExecutionExceptionHandlerTests.java",
+		"**TestInstanceFactoryTests.java",
+		"**TestTemplateInvocationTestDescriptorTests.java",
+		"**TestTemplateInvocationTests.java",
+		"**TestTemplateTestDescriptorTests.java",
+		"**TestWatcherTests.java",
+		"**TimeoutExtensionTests.java",
+		"**UniqueIdTrackingListenerIntegrationTests.java",
+		"**WorkerThreadPoolHierarchicalTestExecutorServiceTests.java",
+		"**org/junit/jupiter/engine/bridge**",
+		// legacy
+		"**documentation/src/test/java/example**",
+		"**testFixtures/java/org/junit/vintage/engine/samples**",
+	)
+	setExportDatatables(true)
+	setFailOnDryRunResults(true)
+}

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionClassLoaderTests.java

@@ -29,7 +29,7 @@
  *
  * @since 5.10
  */
-public class DisabledIfConditionClassLoaderTests {
+class DisabledIfConditionClassLoaderTests {
 
 	@Test
 	// No need to introduce a "disabled" version of this test, since it would simply be the

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class DisabledIfConditionTests extends AbstractExecutionConditionTests {
+class DisabledIfConditionTests extends AbstractExecutionConditionTests {
 
 	@Override
 	protected ExecutionCondition getExecutionCondition() {

jupiter-tests/src/test/java/org/junit/jupiter/api/condition/DisabledIfIntegrationTests.java

@@ -21,7 +21,7 @@
  *
  * @since 5.7
  */
-public class DisabledIfIntegrationTests {
+class DisabledIfIntegrationTests {
 
 	@Test
 	@Disabled("Only used in a unit test via reflection")