Merge pull request #377 from oseemann/large_json

Fix decoding large json arrays

Author: julien-duponchelle

.github/workflows/pytest.yml

@@ -1,5 +1,5 @@
 name: PyTest
-on: push
+on: [push, pull_request]
 
 jobs:
   test:

pymysqlreplication/packet.py

@@ -402,9 +402,9 @@ def read_binary_json_type_inlined(self, t, large):
         elif t == JSONB_TYPE_UINT16:
             return self.read_uint32() if large else self.read_uint16()
         elif t == JSONB_TYPE_INT32:
-            return self.read_int64() if large else self.read_int32()
+            return self.read_int32()
         elif t == JSONB_TYPE_UINT32:
-            return self.read_uint64() if large else self.read_uint32()
+            return self.read_uint32()
 
         raise ValueError('Json type %d is not handled' % t)
 

pymysqlreplication/tests/test_data_type.py

@@ -513,6 +513,16 @@ def test_json_large(self):
 
         self.assertEqual(event.rows[0]["values"]["value"], to_binary_dict(data))
 
+    def test_json_large_array(self):
+        "Test json array larger than 64k bytes"
+        if not self.isMySQL57():
+            self.skipTest("Json is only supported in mysql 5.7")
+        create_query = "CREATE TABLE test (id int, value json);"
+        large_array = dict(my_key=[i for i in range(100000)])
+        insert_query = "INSERT INTO test (id, value) VALUES (1, '%s');" % (json.dumps(large_array),)
+        event = self.create_and_insert_value(create_query, insert_query)
+        self.assertEqual(event.rows[0]["values"]["value"], to_binary_dict(large_array))
+
     def test_json_large_with_literal(self):
         if not self.isMySQL57():
             self.skipTest("Json is only supported in mysql 5.7")