Merge pull request #110 from jasonzzz/master

add support for Stop Event, update tests

Author: julien-duponchelle

pymysqlreplication/binlogstream.py

@@ -8,11 +8,11 @@
 from pymysql.util import int2byte
 
 from .packet import BinLogPacketWrapper
-from .constants.BINLOG import TABLE_MAP_EVENT, ROTATE_EVENT
+from .constants.BINLOG import TABLE_MAP_EVENT, ROTATE_EVENT, STOP_EVENT
 from .gtid import GtidSet
 from .event import (
     QueryEvent, RotateEvent, FormatDescriptionEvent,
-    XidEvent, GtidEvent, NotImplementedEvent)
+    XidEvent, GtidEvent, StopEvent, NotImplementedEvent)
 from .row_event import (
     UpdateRowsEvent, WriteRowsEvent, DeleteRowsEvent, TableMapEvent)
 
@@ -292,6 +292,7 @@ def _allowed_event_list(self, only_events, ignored_events,
             events = set((
                 QueryEvent,
                 RotateEvent,
+                StopEvent,
                 FormatDescriptionEvent,
                 XidEvent,
                 GtidEvent,

pymysqlreplication/event.py

@@ -95,6 +95,10 @@ class FormatDescriptionEvent(BinLogEvent):
     pass
 
 
+class StopEvent(BinLogEvent):
+    pass
+
+
 class XidEvent(BinLogEvent):
     """A COMMIT event
 

pymysqlreplication/packet.py

@@ -33,7 +33,7 @@ class BinLogPacketWrapper(object):
         constants.XID_EVENT: event.XidEvent,
         constants.INTVAR_EVENT: event.NotImplementedEvent,
         constants.GTID_LOG_EVENT: event.GtidEvent,
-        constants.STOP_EVENT: event.NotImplementedEvent,
+        constants.STOP_EVENT: event.StopEvent,
         # row_event
         constants.UPDATE_ROWS_EVENT_V1: row_event.UpdateRowsEvent,
         constants.WRITE_ROWS_EVENT_V1: row_event.WriteRowsEvent,

pymysqlreplication/tests/test_basic.py

@@ -14,9 +14,9 @@ def ignoredEvents(self):
         return [GtidEvent]
 
     def test_allowed_event_list(self):
-        self.assertEqual(len(self.stream._allowed_event_list(None, None, False)), 10)
-        self.assertEqual(len(self.stream._allowed_event_list(None, None, True)), 9)
-        self.assertEqual(len(self.stream._allowed_event_list(None, [RotateEvent], False)), 9)
+        self.assertEqual(len(self.stream._allowed_event_list(None, None, False)), 11)
+        self.assertEqual(len(self.stream._allowed_event_list(None, None, True)), 10)
+        self.assertEqual(len(self.stream._allowed_event_list(None, [RotateEvent], False)), 10)
         self.assertEqual(len(self.stream._allowed_event_list([RotateEvent], None, False)), 1)
 
     def test_read_query_event(self):