[fix] jsx-curly-brace-presence: allow necessary white-space literal

Author: Cory Brown

lib/rules/jsx-curly-brace-presence.js

@@ -6,6 +6,8 @@
 
 'use strict';
 
+const arrayIncludes = require('array-includes');
+
 const docsUrl = require('../util/docsUrl');
 const jsxUtil = require('../util/jsx');
 
@@ -70,7 +72,7 @@ module.exports = {
     }
 
     function containsBackslash(rawStringValue) {
-      return rawStringValue.includes('\\');
+      return arrayIncludes(rawStringValue, '\\');
     }
 
     function containsHTMLEntity(rawStringValue) {
@@ -238,7 +240,12 @@ module.exports = {
 
       return adjSiblings.some(x => x.type && x.type === 'JSXExpressionContainer');
     }
+    function hasAdjacentJsx(node, children) {
+      const childrenExcludingWhitespaceLiteral = children.filter(child => !isWhiteSpaceLiteral(child));
+      const adjSiblings = getAdjacentSiblings(node, childrenExcludingWhitespaceLiteral);
 
+      return adjSiblings.some(x => x.type && arrayIncludes(['JSXExpressionContainer', 'JSXElement'], x.type));
+    }
     function shouldCheckForUnnecessaryCurly(parent, node, config) {
       // Bail out if the parent is a JSXAttribute & its contents aren't
       // StringLiteral or TemplateLiteral since e.g
@@ -259,7 +266,9 @@ module.exports = {
       if (jsxUtil.isJSX(parent) && hasAdjacentJsxExpressionContainers(node, parent.children)) {
         return false;
       }
-
+      if (containsWhitespaceExpression(node) && hasAdjacentJsx(node, parent.children)) {
+        return false;
+      }
       if (
         parent.children &&
         parent.children.length === 1 &&

tests/lib/rules/jsx-curly-brace-presence.js

@@ -85,6 +85,25 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
       code: '<App>{`Hello ${word} World`}</App>',
       options: [{children: 'never'}]
     },
+    {
+      code: `
+      <React.Fragment>
+        foo{' '}
+        <span>bar</span>
+      </React.Fragment>
+    `,
+      options: [{children: 'never'}]
+    },
+    {
+      code: `
+      <>
+        foo{' '}
+        <span>bar</span>
+      </>
+    `,
+      parser: parsers.BABEL_ESLINT,
+      options: [{children: 'never'}]
+    },
     {
       code: '<App>{`Hello \\n World`}</App>',
       options: [{children: 'never'}]