[Fix] no-typos: avoid crash on spread syntax in createReactClass object

Fixes #2816.

Author: Songyu-Wang

CHANGELOG.md

@@ -7,7 +7,9 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 
 ## Fixed
 * [`prop-types`]: fix Cannot read property 'type' of undefined error when destructured param ([#2807][] @minwe)
+* [`no-typos`]: avoid crash on spread syntax in createReactClass object ([#2816][] @ljharb @Songyu-Wang)
 
+[#2816]: https://github.com/yannickcr/eslint-plugin-react/issues/2816
 [#2807]: https://github.com/yannickcr/eslint-plugin-react/pull/2807
 
 ## [7.21.2] - 2020.09.24

lib/rules/no-typos.js

@@ -240,8 +240,10 @@ module.exports = {
         }
 
         node.properties.forEach((property) => {
-          reportErrorIfPropertyCasingTypo(property.value, property.key, false);
-          reportErrorIfLifecycleMethodCasingTypo(property);
+          if (property.type !== 'SpreadElement') {
+            reportErrorIfPropertyCasingTypo(property.value, property.key, false);
+            reportErrorIfLifecycleMethodCasingTypo(property);
+          }
         });
       }
     };

tests/lib/rules/no-typos.js

@@ -33,6 +33,22 @@ const ERROR_MESSAGE_STATIC = (method) => `Lifecycle method should be static: ${m
 const ruleTester = new RuleTester();
 ruleTester.run('no-typos', rule, {
   valid: [{
+    code: `
+        import createReactClass from 'create-react-class'
+        function hello (extra = {}) {
+          return createReactClass({
+            noteType: 'hello',
+            renderItem () {
+              return null
+            },
+            ...extra
+          })
+        }
+    `,
+    parser: parsers.TYPESCRIPT_ESLINT,
+    parserOptions
+  },
+  {
     code: `
       class First {
         static PropTypes = {key: "myValue"};