Changed warnings in no-deprecated rule, deprecated old lifecycle methods in favor of UNSAFE_*

sergei-startsev · ljharb · commit 7034ffcb7ad4 · 2018-04-02T13:23:24.000+03:00
diff --git a/lib/rules/no-deprecated.js b/lib/rules/no-deprecated.js
@@ -79,17 +79,17 @@ module.exports = {
       // 16.3.0
       deprecated.componentWillMount = [
         '16.3.0',
-        'constructor',
+        'UNSAFE_componentWillMount',
         'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
       ];
       deprecated.componentWillReceiveProps = [
         '16.3.0',
-        'getDerivedStateFromProps',
+        'UNSAFE_componentWillReceiveProps',
         'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
       ];
       deprecated.componentWillUpdate = [
         '16.3.0',
-        'getDerivedStateFromProps',
+        'UNSAFE_componentWillUpdate',
         'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
       ];
       return deprecated;
diff --git a/tests/lib/rules/no-deprecated.js b/tests/lib/rules/no-deprecated.js
@@ -221,18 +221,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -251,18 +251,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -279,18 +279,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -307,18 +307,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -335,18 +335,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }
@@ -363,18 +363,18 @@ ruleTester.run('no-deprecated', rule, {
       errors: [
         {
           message: errorMessage(
-            'componentWillMount', '16.3.0', 'constructor',
+            'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'
           )
         },
         {
           message: errorMessage(
-            'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',
+            'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'
           )
         },
         {
-          message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',
+          message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',
             'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'
           )
         }

Original file line number	Diff line number	Diff line change
`@@ -221,18 +221,18 @@ ruleTester.run('no-deprecated', rule, {`
`221`	`221`	`errors: [`
`222`	`222`	`{`
`223`	`223`	`message: errorMessage(`
`224`		`- 'componentWillMount', '16.3.0', 'constructor',`
	`224`	`+ 'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',`
`225`	`225`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'`
`226`	`226`	`)`
`227`	`227`	`},`
`228`	`228`	`{`
`229`	`229`	`message: errorMessage(`
`230`		`- 'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',`
	`230`	`+ 'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',`
`231`	`231`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'`
`232`	`232`	`)`
`233`	`233`	`},`
`234`	`234`	`{`
`235`		`- message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',`
	`235`	`+ message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',`
`236`	`236`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'`
`237`	`237`	`)`
`238`	`238`	`}`
`@@ -251,18 +251,18 @@ ruleTester.run('no-deprecated', rule, {`
`251`	`251`	`errors: [`
`252`	`252`	`{`
`253`	`253`	`message: errorMessage(`
`254`		`- 'componentWillMount', '16.3.0', 'constructor',`
	`254`	`+ 'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',`
`255`	`255`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'`
`256`	`256`	`)`
`257`	`257`	`},`
`258`	`258`	`{`
`259`	`259`	`message: errorMessage(`
`260`		`- 'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',`
	`260`	`+ 'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',`
`261`	`261`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'`
`262`	`262`	`)`
`263`	`263`	`},`
`264`	`264`	`{`
`265`		`- message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',`
	`265`	`+ message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',`
`266`	`266`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'`
`267`	`267`	`)`
`268`	`268`	`}`
`@@ -279,18 +279,18 @@ ruleTester.run('no-deprecated', rule, {`
`279`	`279`	`errors: [`
`280`	`280`	`{`
`281`	`281`	`message: errorMessage(`
`282`		`- 'componentWillMount', '16.3.0', 'constructor',`
	`282`	`+ 'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',`
`283`	`283`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'`
`284`	`284`	`)`
`285`	`285`	`},`
`286`	`286`	`{`
`287`	`287`	`message: errorMessage(`
`288`		`- 'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',`
	`288`	`+ 'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',`
`289`	`289`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'`
`290`	`290`	`)`
`291`	`291`	`},`
`292`	`292`	`{`
`293`		`- message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',`
	`293`	`+ message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',`
`294`	`294`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'`
`295`	`295`	`)`
`296`	`296`	`}`
`@@ -307,18 +307,18 @@ ruleTester.run('no-deprecated', rule, {`
`307`	`307`	`errors: [`
`308`	`308`	`{`
`309`	`309`	`message: errorMessage(`
`310`		`- 'componentWillMount', '16.3.0', 'constructor',`
	`310`	`+ 'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',`
`311`	`311`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'`
`312`	`312`	`)`
`313`	`313`	`},`
`314`	`314`	`{`
`315`	`315`	`message: errorMessage(`
`316`		`- 'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',`
	`316`	`+ 'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',`
`317`	`317`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'`
`318`	`318`	`)`
`319`	`319`	`},`
`320`	`320`	`{`
`321`		`- message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',`
	`321`	`+ message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',`
`322`	`322`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'`
`323`	`323`	`)`
`324`	`324`	`}`
`@@ -335,18 +335,18 @@ ruleTester.run('no-deprecated', rule, {`
`335`	`335`	`errors: [`
`336`	`336`	`{`
`337`	`337`	`message: errorMessage(`
`338`		`- 'componentWillMount', '16.3.0', 'constructor',`
	`338`	`+ 'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',`
`339`	`339`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'`
`340`	`340`	`)`
`341`	`341`	`},`
`342`	`342`	`{`
`343`	`343`	`message: errorMessage(`
`344`		`- 'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',`
	`344`	`+ 'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',`
`345`	`345`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'`
`346`	`346`	`)`
`347`	`347`	`},`
`348`	`348`	`{`
`349`		`- message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',`
	`349`	`+ message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',`
`350`	`350`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'`
`351`	`351`	`)`
`352`	`352`	`}`
`@@ -363,18 +363,18 @@ ruleTester.run('no-deprecated', rule, {`
`363`	`363`	`errors: [`
`364`	`364`	`{`
`365`	`365`	`message: errorMessage(`
`366`		`- 'componentWillMount', '16.3.0', 'constructor',`
	`366`	`+ 'componentWillMount', '16.3.0', 'UNSAFE_componentWillMount',`
`367`	`367`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillmount'`
`368`	`368`	`)`
`369`	`369`	`},`
`370`	`370`	`{`
`371`	`371`	`message: errorMessage(`
`372`		`- 'componentWillReceiveProps', '16.3.0', 'getDerivedStateFromProps',`
	`372`	`+ 'componentWillReceiveProps', '16.3.0', 'UNSAFE_componentWillReceiveProps',`
`373`	`373`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops'`
`374`	`374`	`)`
`375`	`375`	`},`
`376`	`376`	`{`
`377`		`- message: errorMessage('componentWillUpdate', '16.3.0', 'getDerivedStateFromProps',`
	`377`	`+ message: errorMessage('componentWillUpdate', '16.3.0', 'UNSAFE_componentWillUpdate',`
`378`	`378`	`'https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate'`
`379`	`379`	`)`
`380`	`380`	`}`