Add shared setting for React version

Author: yannickcr

README.md

@@ -37,7 +37,8 @@ You can also specify some settings that will be shared across all the plugin rul
 {
   "settings": {
     "react": {
-      "pragma": "React" // Pragma to use, default to "React"
+      "pragma": "React",  // Pragma to use, default to "React"
+      "version": "0.14.0" // React version, default to the latest React stable release
     }
   }
 }

docs/rules/no-deprecated.md

@@ -29,6 +29,8 @@ ReactDOM.findDOMNode(this.refs.foo);
 
 ## Rule Options
 
+**Deprecation notice**: This option is deprecated, please use the [shared settings](/README.md#configuration) to specify the React version.
+
 By default this rule will warn to every methods marked as deprecated. You can limit it to an older React version if you are not using the latest one:
 
 ```js

lib/rules/no-deprecated.js

@@ -6,6 +6,7 @@
 'use strict';
 
 var pragmaUtil = require('../util/pragma');
+var versionUtil = require('../util/version');
 
 // ------------------------------------------------------------------------------
 // Constants
@@ -20,15 +21,6 @@ var DEPRECATED_MESSAGE = '{{oldMethod}} is deprecated since React {{version}}{{n
 module.exports = function(context) {
 
   var sourceCode = context.getSourceCode();
-
-  // Validate React version passed in options
-  // (append the patch version if missing, allowing shorthands like 0.12 for React 0.12.0)
-  var optVer = context.options[0] ? context.options[0].react : '999.999.999';
-  optVer = /^[0-9]+\.[0-9]+$/.test(optVer) ? optVer + '.0' : optVer;
-  optVer = optVer.split('.').map(function(part) {
-    return Number(part);
-  });
-
   var pragma = pragmaUtil.getFromContext(context);
 
   function getDeprecated() {
@@ -60,24 +52,13 @@ module.exports = function(context) {
     return deprecated;
   }
 
-  function checkVersion(methodVer) {
-    methodVer = methodVer.split('.').map(function(part) {
-      return Number(part);
-    });
-    var higherMajor = methodVer[0] < optVer[0];
-    var higherMinor = methodVer[0] === optVer[0] && methodVer[1] < optVer[1];
-    var higherOrEqualPatch = methodVer[0] === optVer[0] && methodVer[1] === optVer[1] && methodVer[2] <= optVer[2];
-
-    return higherMajor || higherMinor || higherOrEqualPatch;
-  }
-
   function isDeprecated(type, method) {
     var deprecated = getDeprecated();
 
     return (
       deprecated[type] &&
       deprecated[type][method] &&
-      checkVersion(deprecated[type][method][0])
+      versionUtil.test(context, deprecated[type][method][0])
     );
   }
 

lib/util/version.js

@@ -0,0 +1,36 @@
+/**
+ * @fileoverview Utility functions for React version configuration
+ * @author Yannick Croissant
+ */
+'use strict';
+
+function getFromContext(context) {
+  var confVer = '999.999.999';
+  // .eslintrc shared settings (http://eslint.org/docs/user-guide/configuring#adding-shared-settings)
+  if (context.settings.react && context.settings.react.version) {
+    confVer = context.settings.react.version;
+  // Deprecated react option, here for backward compatibility
+  } else if (context.options[0] && context.options[0].react) {
+    confVer = context.options[0].react;
+  }
+  confVer = /^[0-9]+\.[0-9]+$/.test(confVer) ? confVer + '.0' : confVer;
+  return confVer.split('.').map(function(part) {
+    return Number(part);
+  });
+}
+
+function test(context, methodVer) {
+  var confVer = getFromContext(context);
+  methodVer = methodVer.split('.').map(function(part) {
+    return Number(part);
+  });
+  var higherMajor = methodVer[0] < confVer[0];
+  var higherMinor = methodVer[0] === confVer[0] && methodVer[1] < confVer[1];
+  var higherOrEqualPatch = methodVer[0] === confVer[0] && methodVer[1] === confVer[1] && methodVer[2] <= confVer[2];
+
+  return higherMajor || higherMinor || higherOrEqualPatch;
+}
+
+module.exports = {
+  test: test
+};

tests/lib/rules/no-deprecated.js

@@ -38,7 +38,8 @@ ruleTester.run('no-deprecated', rule, {
     'ReactDOMServer.renderToString(element);',
     'ReactDOMServer.renderToStaticMarkup(element);',
     // Deprecated in a later version
-    {code: 'React.renderComponent()', options: [{react: '0.11.0'}]}
+    {code: 'React.renderComponent()', options: [{react: '0.11.0'}]},
+    {code: 'React.renderComponent()', settings: {react: {version: '0.11.0'}}}
   ],
 
   invalid: [{