Fix no-find-dom-node detection

Author: yannickcr

lib/rules/no-find-dom-node.js

@@ -18,24 +18,20 @@ module.exports = function(context) {
 
     CallExpression: function(node) {
       var callee = node.callee;
-      if (
-        callee.type !== 'MemberExpression' || (
-          callee.object.callee && callee.object.callee.name !== 'findDOMNode' &&
-          callee.property.name !== 'findDOMNode'
-        )
-      ) {
+
+      var isfindDOMNode =
+        (callee.object && callee.object.callee && callee.object.callee.name === 'findDOMNode') ||
+        (callee.property && callee.property.name === 'findDOMNode')
+      ;
+
+      if (!isfindDOMNode) {
         return;
       }
-      var ancestors = context.getAncestors(callee);
-      for (var i = 0, j = ancestors.length; i < j; i++) {
-        if (ancestors[i].type === 'Property' || ancestors[i].type === 'MethodDefinition') {
-          context.report({
-            node: callee,
-            message: 'Do not use findDOMNode'
-          });
-          break;
-        }
-      }
+
+      context.report({
+        node: callee,
+        message: 'Do not use findDOMNode'
+      });
     }
   };
 

tests/lib/rules/no-find-dom-node.js

@@ -52,6 +52,18 @@ ruleTester.run('no-find-dom-node', rule, {
       '});'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    code: [
+      'var Hello = React.createClass({',
+      '  componentDidMount: function() {',
+      '    React.someFunc(this);',
+      '  },',
+      '  render: function() {',
+      '    return <div>Hello</div>;',
+      '  }',
+      '});'
+    ].join('\n'),
+    parserOptions: parserOptions
   }],
 
   invalid: [{