Check template literals in no-literals

Author: davidyorr

lib/rules/jsx-no-literals.js

@@ -64,6 +64,12 @@ module.exports = {
         if (getValidation(node)) {
           reportLiteralNode(node);
         }
+      },
+
+      TemplateLiteral: function(node) {
+        if (isNoStrings && node.parent.type === 'JSXExpressionContainer') {
+          reportLiteralNode(node);
+        }
       }
 
     };

tests/lib/rules/jsx-no-literals.js

@@ -138,6 +138,36 @@ ruleTester.run('jsx-no-literals', rule, {
       code: '<Foo bar={100} />',
       parser: 'babel-eslint',
       options: [{noStrings: true}]
+    }, {
+      code: '<Foo bar={null} />',
+      parser: 'babel-eslint',
+      options: [{noStrings: true}]
+    }, {
+      code: '<Foo bar={{}} />',
+      parser: 'babel-eslint',
+      options: [{noStrings: true}]
+    }, {
+      code: [
+        'class Comp1 extends Component {',
+        '  asdf() {}',
+        '  render() {',
+        '    return <Foo bar={this.asdf} />;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      options: [{noStrings: true}]
+    }, {
+      code: [
+        'class Comp1 extends Component {',
+        '  render() {',
+        '    let foo = `bar`;',
+        '    return <div />;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      options: [{noStrings: true}]
     }, {
       code: `
         <Foo bar="test">
@@ -161,6 +191,32 @@ ruleTester.run('jsx-no-literals', rule, {
     }, {
       code: '<Foo bar={100} />',
       options: [{noStrings: true}]
+    }, {
+      code: '<Foo bar={null} />',
+      options: [{noStrings: true}]
+    }, {
+      code: '<Foo bar={{}} />',
+      options: [{noStrings: true}]
+    }, {
+      code: [
+        'class Comp1 extends Component {',
+        '  asdf() {}',
+        '  render() {',
+        '    return <Foo bar={this.asdf} />;',
+        '  }',
+        '}'
+      ].join('\n'),
+      options: [{noStrings: true}]
+    }, {
+      code: [
+        'class Comp1 extends Component {',
+        '  render() {',
+        '    let foo = `bar`;',
+        '    return <div />;',
+        '  }',
+        '}'
+      ].join('\n'),
+      options: [{noStrings: true}]
     }
 
   ],
@@ -289,6 +345,32 @@ ruleTester.run('jsx-no-literals', rule, {
       `,
       options: [{noStrings: true}],
       errors: [{message: 'Strings not allowed in JSX files'}]
+    }, {
+      code: [
+        '<Foo>',
+        '  {`Test`}',
+        '</Foo>'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      options: [{noStrings: true}],
+      errors: [{message: 'Strings not allowed in JSX files'}]
+    }, {
+      code: [
+        '<Foo>',
+        '  {`Test`}',
+        '</Foo>'
+      ].join('\n'),
+      options: [{noStrings: true}],
+      errors: [{message: 'Strings not allowed in JSX files'}]
+    }, {
+      code: '<Foo bar={`Test`} />',
+      parser: 'babel-eslint',
+      options: [{noStrings: true}],
+      errors: [{message: 'Strings not allowed in JSX files'}]
+    }, {
+      code: '<Foo bar={`Test`} />',
+      options: [{noStrings: true}],
+      errors: [{message: 'Strings not allowed in JSX files'}]
     }
   ]
 });