[Fix] Never call Object prototype builtins directly.

See #955.

Author: ljharb

.eslintrc

@@ -152,6 +152,7 @@
         "max-len": [2, 120],
         "max-params": 0,
         "max-statements": 0,
-        "no-plusplus": 0
+        "no-plusplus": 0,
+        "no-prototype-builtins": 2
     }
 }

index.js

@@ -1,5 +1,7 @@
 'use strict';
 
+var has = require('has');
+
 var allRules = {
   'jsx-uses-react': require('./lib/rules/jsx-uses-react'),
   'no-multi-comp': require('./lib/rules/no-multi-comp'),
@@ -64,7 +66,7 @@ var allRules = {
 function filterRules(rules, predicate) {
   var result = {};
   for (var key in rules) {
-    if (rules.hasOwnProperty(key) && predicate(rules[key])) {
+    if (has(rules, key) && predicate(rules[key])) {
       result[key] = rules[key];
     }
   }
@@ -74,7 +76,7 @@ function filterRules(rules, predicate) {
 function configureAsError(rules) {
   var result = {};
   for (var key in rules) {
-    if (!rules.hasOwnProperty(key)) {
+    if (!has(rules, key)) {
       continue;
     }
     result['react/' + key] = 2;

lib/rules/display-name.js

@@ -4,6 +4,7 @@
  */
 'use strict';
 
+var has = require('has');
 var Components = require('../util/Components');
 
 // ------------------------------------------------------------------------------
@@ -223,7 +224,7 @@ module.exports = {
         var list = components.list();
         // Report missing display name for all components
         for (var component in list) {
-          if (!list.hasOwnProperty(component) || list[component].hasDisplayName) {
+          if (!has(list, component) || list[component].hasDisplayName) {
             continue;
           }
           reportMissingDisplayName(list[component]);

lib/rules/jsx-closing-bracket-location.js

@@ -4,6 +4,8 @@
  */
 'use strict';
 
+var has = require('has');
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -70,16 +72,16 @@ module.exports = {
       options.selfClosing = config;
     } else if (typeof config === 'object') {
       // [1, {location: 'something'}] (back-compat)
-      if (config.hasOwnProperty('location')) {
+      if (has(config, 'location')) {
         options.nonEmpty = config.location;
         options.selfClosing = config.location;
       }
       // [1, {nonEmpty: 'something'}]
-      if (config.hasOwnProperty('nonEmpty')) {
+      if (has(config, 'nonEmpty')) {
         options.nonEmpty = config.nonEmpty;
       }
       // [1, {selfClosing: 'something'}]
-      if (config.hasOwnProperty('selfClosing')) {
+      if (has(config, 'selfClosing')) {
         options.selfClosing = config.selfClosing;
       }
     }

lib/rules/jsx-max-props-per-line.js

@@ -5,6 +5,8 @@
 
 'use strict';
 
+var has = require('has');
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -55,7 +57,7 @@ module.exports = {
         });
 
         for (var line in props) {
-          if (!props.hasOwnProperty(line)) {
+          if (!has(props, line)) {
             continue;
           }
           if (props[line].length > maximum) {

lib/rules/jsx-no-duplicate-props.js

@@ -5,6 +5,8 @@
 
 'use strict';
 
+var has = require('has');
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -48,7 +50,7 @@ module.exports = {
             name = name.toLowerCase();
           }
 
-          if (props.hasOwnProperty(name)) {
+          if (has(props, name)) {
             context.report({
               node: decl,
               message: 'No duplicate props allowed'

lib/rules/jsx-tag-spacing.js

@@ -4,6 +4,7 @@
  */
 'use strict';
 
+var has = require('has');
 var getTokenBeforeClosingBracket = require('../util/getTokenBeforeClosingBracket');
 
 // ------------------------------------------------------------------------------
@@ -204,11 +205,9 @@ module.exports = {
       beforeSelfClosing: 'always',
       afterOpening: 'never'
     };
-    if (context.options[0]) {
-      for (var key in options) {
-        if (options.hasOwnProperty(key) && context.options[0].hasOwnProperty(key)) {
-          options[key] = context.options[0][key];
-        }
+    for (var key in options) {
+      if (has(options, key) && has(context.options[0] || {}, key)) {
+        options[key] = context.options[0][key];
       }
     }
 

lib/rules/jsx-wrap-multilines.js

@@ -4,6 +4,8 @@
  */
 'use strict';
 
+var has = require('has');
+
 // ------------------------------------------------------------------------------
 // Constants
 // ------------------------------------------------------------------------------
@@ -79,7 +81,7 @@ module.exports = {
 
     function isEnabled(type) {
       var userOptions = context.options[0] || {};
-      if (({}).hasOwnProperty.call(userOptions, type)) {
+      if (has(userOptions, type)) {
         return userOptions[type];
       }
       return DEFAULTS[type];

lib/rules/no-array-index-key.js

@@ -4,6 +4,8 @@
  */
 'use strict';
 
+var has = require('has');
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -50,7 +52,7 @@ module.exports = {
       if (callee.property.type !== 'Identifier') {
         return null;
       }
-      if (!iteratorFunctionsToIndexParamPosition.hasOwnProperty(callee.property.name)) {
+      if (!has(iteratorFunctionsToIndexParamPosition, callee.property.name)) {
         return null;
       }
 

lib/rules/no-direct-mutation-state.js

@@ -4,6 +4,7 @@
  */
 'use strict';
 
+var has = require('has');
 var Components = require('../util/Components');
 
 // ------------------------------------------------------------------------------
@@ -76,7 +77,7 @@ module.exports = {
       'Program:exit': function() {
         var list = components.list();
         for (var component in list) {
-          if (!list.hasOwnProperty(component) || isValid(list[component])) {
+          if (!has(list, component) || isValid(list[component])) {
             continue;
           }
           reportMutations(list[component]);