fix(DatePicker): strictmode issue preventing value from updating

jquense · jquense · commit fecbf4d49440 · 2021-04-26T10:34:17.000-04:00
fixes #1074
diff --git a/packages/react-widgets/src/DatePickerInput.tsx b/packages/react-widgets/src/DatePickerInput.tsx
@@ -50,11 +50,11 @@ const DatePickerInput = React.forwardRef(
       [value, formatter, localizer, displayFormat, editing, editFormat],
     )
 
-    const lastValueFromProps = useRef(nextTextValue)
+    const [prevValue, setPrevValue] = useState(nextTextValue)
     const [textValue, setTextValue] = useState(nextTextValue)
 
-    if (lastValueFromProps.current !== nextTextValue) {
-      lastValueFromProps.current = nextTextValue
+    if (prevValue !== nextTextValue) {
+      setPrevValue(nextTextValue)
       setTextValue(nextTextValue)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -50,11 +50,11 @@ const DatePickerInput = React.forwardRef(`
`50`	`50`	`[value, formatter, localizer, displayFormat, editing, editFormat],`
`51`	`51`	`)`
`52`	`52`
`53`		`- const lastValueFromProps = useRef(nextTextValue)`
	`53`	`+ const [prevValue, setPrevValue] = useState(nextTextValue)`
`54`	`54`	`const [textValue, setTextValue] = useState(nextTextValue)`
`55`	`55`
`56`		`- if (lastValueFromProps.current !== nextTextValue) {`
`57`		`- lastValueFromProps.current = nextTextValue`
	`56`	`+ if (prevValue !== nextTextValue) {`
	`57`	`+ setPrevValue(nextTextValue)`
`58`	`58`	`setTextValue(nextTextValue)`
`59`	`59`	`}`
`60`	`60`