Merge branch '2.7' into 2.8

nicolas-grekas · nicolas-grekas · commit d64f0d4b4a73 · 2017-10-01T23:00:16.000+02:00
* 2.7: (22 commits)
  Tests and fix for issue in array model data in EntityType field with multiple=true
  [Form] Fixed PercentToLocalizedStringTransformer to accept both comma and dot as decimal separator, if possible
  removed useless PHPDoc
  [Form] Fix FormInterface::submit() annotation
  PdoSessionHandler: fix advisory lock for pgsql when session.sid_bits_per_character &gt; 4
  HttpCache does not consider ESI resources in HEAD requests
  Fix translation for "This field was not expected"
  [Routing] Enhance Route(Collection) docblocks
  Added improvement for accuracy in MoneyToLocalizedStringTransformer.
  Removed unused private property
  Use correct verb form in the pull request template
  Use PHP_MAXPATHLEN in Filesystem.
  Added null as explicit return type (?TokenInterface)
  [FrameworkBundle] Fix Routing\DelegatingLoader
  Render all line breaks according to the exception message
  [Form] Fix phpdoc
  [DI] remove confusing code
  [Form] Fixed GroupSequence with "constraints" option
  [Validator] Clarify UUID validator behavior
  [Filesystem] Fixed makePathRelative
  ...
diff --git a/Adapter/AbstractFindAdapter.php b/Adapter/AbstractFindAdapter.php
@@ -35,9 +35,6 @@ abstract class AbstractFindAdapter extends AbstractAdapter
      */
     protected $shell;
 
-    /**
-     * Constructor.
-     */
     public function __construct()
     {
         $this->shell = new Shell();
diff --git a/Comparator/DateComparator.php b/Comparator/DateComparator.php
@@ -19,8 +19,6 @@
 class DateComparator extends Comparator
 {
     /**
-     * Constructor.
-     *
      * @param string $test A comparison string
      *
      * @throws \InvalidArgumentException If the test is not understood
diff --git a/Comparator/NumberComparator.php b/Comparator/NumberComparator.php
@@ -35,8 +35,6 @@
 class NumberComparator extends Comparator
 {
     /**
-     * Constructor.
-     *
      * @param string|int $test A comparison string or an integer
      *
      * @throws \InvalidArgumentException If the test is not understood
diff --git a/Finder.php b/Finder.php
@@ -67,9 +67,6 @@ class Finder implements \IteratorAggregate, \Countable
 
     private static $vcsPatterns = array('.svn', '_svn', 'CVS', '_darcs', '.arch-params', '.monotone', '.bzr', '.git', '.hg');
 
-    /**
-     * Constructor.
-     */
     public function __construct()
     {
         $this->ignore = static::IGNORE_VCS_FILES | static::IGNORE_DOT_FILES;
diff --git a/Iterator/CustomFilterIterator.php b/Iterator/CustomFilterIterator.php
@@ -24,8 +24,6 @@ class CustomFilterIterator extends FilterIterator
     private $filters = array();
 
     /**
-     * Constructor.
-     *
      * @param \Iterator  $iterator The Iterator to filter
      * @param callable[] $filters  An array of PHP callbacks
      *
diff --git a/Iterator/DateRangeFilterIterator.php b/Iterator/DateRangeFilterIterator.php
@@ -23,8 +23,6 @@ class DateRangeFilterIterator extends FilterIterator
     private $comparators = array();
 
     /**
-     * Constructor.
-     *
      * @param \Iterator        $iterator    The Iterator to filter
      * @param DateComparator[] $comparators An array of DateComparator instances
      */
diff --git a/Iterator/DepthRangeFilterIterator.php b/Iterator/DepthRangeFilterIterator.php
@@ -21,8 +21,6 @@ class DepthRangeFilterIterator extends FilterIterator
     private $minDepth = 0;
 
     /**
-     * Constructor.
-     *
      * @param \RecursiveIteratorIterator $iterator The Iterator to filter
      * @param int                        $minDepth The min depth
      * @param int                        $maxDepth The max depth
diff --git a/Iterator/ExcludeDirectoryFilterIterator.php b/Iterator/ExcludeDirectoryFilterIterator.php
@@ -24,8 +24,6 @@ class ExcludeDirectoryFilterIterator extends FilterIterator implements \Recursiv
     private $excludedPattern;
 
     /**
-     * Constructor.
-     *
      * @param \Iterator $iterator    The Iterator to filter
      * @param array     $directories An array of directories to exclude
      */
diff --git a/Iterator/FileTypeFilterIterator.php b/Iterator/FileTypeFilterIterator.php
@@ -24,8 +24,6 @@ class FileTypeFilterIterator extends FilterIterator
     private $mode;
 
     /**
-     * Constructor.
-     *
      * @param \Iterator $iterator The Iterator to filter
      * @param int       $mode     The mode (self::ONLY_FILES or self::ONLY_DIRECTORIES)
      */
diff --git a/Iterator/MultiplePcreFilterIterator.php b/Iterator/MultiplePcreFilterIterator.php
@@ -22,8 +22,6 @@ abstract class MultiplePcreFilterIterator extends FilterIterator
     protected $noMatchRegexps = array();
 
     /**
-     * Constructor.
-     *
      * @param \Iterator $iterator        The Iterator to filter
      * @param array     $matchPatterns   An array of patterns that need to match
      * @param array     $noMatchPatterns An array of patterns that need to not match
diff --git a/Iterator/RecursiveDirectoryIterator.php b/Iterator/RecursiveDirectoryIterator.php
@@ -37,8 +37,6 @@ class RecursiveDirectoryIterator extends \RecursiveDirectoryIterator
     private $directorySeparator = '/';
 
     /**
-     * Constructor.
-     *
      * @param string $path
      * @param int    $flags
      * @param bool   $ignoreUnreadableDirs
diff --git a/Iterator/SizeRangeFilterIterator.php b/Iterator/SizeRangeFilterIterator.php
@@ -23,8 +23,6 @@ class SizeRangeFilterIterator extends FilterIterator
     private $comparators = array();
 
     /**
-     * Constructor.
-     *
      * @param \Iterator          $iterator    The Iterator to filter
      * @param NumberComparator[] $comparators An array of NumberComparator instances
      */
diff --git a/Iterator/SortableIterator.php b/Iterator/SortableIterator.php
@@ -28,8 +28,6 @@ class SortableIterator implements \IteratorAggregate
     private $sort;
 
     /**
-     * Constructor.
-     *
      * @param \Traversable $iterator The Iterator to filter
      * @param int|callable $sort     The sort type (SORT_BY_NAME, SORT_BY_TYPE, or a PHP callback)
      *
diff --git a/Shell/Command.php b/Shell/Command.php
@@ -41,8 +41,6 @@ class Command
     private $errorHandler;
 
     /**
-     * Constructor.
-     *
      * @param Command|null $parent Parent command
      */
     public function __construct(Command $parent = null)
diff --git a/SplFileInfo.php b/SplFileInfo.php
@@ -22,8 +22,6 @@ class SplFileInfo extends \SplFileInfo
     private $relativePathname;
 
     /**
-     * Constructor.
-     *
      * @param string $file             The file name
      * @param string $relativePath     The relative path
      * @param string $relativePathname The relative path name

Original file line number	Diff line number	Diff line change
`@@ -35,9 +35,6 @@ abstract class AbstractFindAdapter extends AbstractAdapter`
`35`	`35`	`*/`
`36`	`36`	`protected $shell;`
`37`	`37`
`38`		`- /**`
`39`		`- * Constructor.`
`40`		`- */`
`41`	`38`	`public function __construct()`
`42`	`39`	`{`
`43`	`40`	`$this->shell = new Shell();`
Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,6 @@`
`19`	`19`	`class DateComparator extends Comparator`
`20`	`20`	`{`
`21`	`21`	`/**`
`22`		`- * Constructor.`
`23`		`- *`
`24`	`22`	`* @param string $test A comparison string`
`25`	`23`	`*`
`26`	`24`	`* @throws \InvalidArgumentException If the test is not understood`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,6 @@`
`35`	`35`	`class NumberComparator extends Comparator`
`36`	`36`	`{`
`37`	`37`	`/**`
`38`		`- * Constructor.`
`39`		`- *`
`40`	`38`	`* @param string\|int $test A comparison string or an integer`
`41`	`39`	`*`
`42`	`40`	`* @throws \InvalidArgumentException If the test is not understood`
Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,6 @@ class Finder implements \IteratorAggregate, \Countable`
`67`	`67`
`68`	`68`	`private static $vcsPatterns = array('.svn', '_svn', 'CVS', '_darcs', '.arch-params', '.monotone', '.bzr', '.git', '.hg');`
`69`	`69`
`70`		`- /**`
`71`		`- * Constructor.`
`72`		`- */`
`73`	`70`	`public function __construct()`
`74`	`71`	`{`
`75`	`72`	`$this->ignore = static::IGNORE_VCS_FILES \| static::IGNORE_DOT_FILES;`
Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,6 @@ class CustomFilterIterator extends FilterIterator`
`24`	`24`	`private $filters = array();`
`25`	`25`
`26`	`26`	`/**`
`27`		`- * Constructor.`
`28`		`- *`
`29`	`27`	`* @param \Iterator $iterator The Iterator to filter`
`30`	`28`	`* @param callable[] $filters An array of PHP callbacks`
`31`	`29`	`*`