Add workflows

Author: johnstevenson

.github/workflows/continuous-integration.yml

@@ -0,0 +1,58 @@
+name: Continuous Integration
+
+on:
+  push:
+    paths-ignore: ["**.md"]
+  pull_request:
+    paths-ignore: ["**.md"]
+
+env:
+  COMPOSER_FLAGS: --ansi --no-interaction --no-progress --prefer-dist
+
+jobs:
+  tests:
+    name: CI
+
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        php-version:
+          - "7.4"
+          - "8.0"
+          - "8.1"
+          - "8.2"
+        os: [ubuntu-latest]
+        include:
+          - php-version: "7.4"
+            os: windows-latest
+          - php-version: "8.2"
+            os: windows-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          coverage: none
+          php-version: ${{ matrix.php-version }}
+
+      - name: Get composer cache directory
+        id: composercache
+        shell: bash
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Restore cached dependencies
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.composercache.outputs.dir }}
+          key: php-${{ matrix.php-version }}-composer-${{ hashFiles('**/composer.json') }}
+          restore-keys: php-${{ matrix.php-version }}-composer-
+
+      - name: Install latest dependencies
+        run: composer update ${{ env.COMPOSER_FLAGS }}
+
+      - name: Run tests
+        run: vendor/bin/phpunit

.github/workflows/lint.yml

@@ -0,0 +1,32 @@
+name: PHP Lint
+
+on:
+  push:
+    paths-ignore: ["**.md"]
+  pull_request:
+    paths-ignore: ["**.md"]
+
+jobs:
+  tests:
+    name: Lint
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        php-version:
+          - "7.4"
+          - "latest"
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          coverage: none
+          php-version: ${{ matrix.php-version }}
+
+      - name: Lint PHP files
+        run: "find src/ -type f -name '*.php' -print0 | xargs -0 -L1 -P4 -- php -l -f"

.github/workflows/phpstan.yml

@@ -0,0 +1,49 @@
+name: PHPStan
+
+on:
+  push:
+    paths-ignore: ["**.md"]
+  pull_request:
+    paths-ignore: ["**.md"]
+
+env:
+  COMPOSER_FLAGS: --ansi --no-interaction --no-progress --prefer-dist
+
+jobs:
+  tests:
+    name: PHPStan
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        php-version:
+          - "8.2"
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          coverage: none
+          php-version: ${{ matrix.php-version }}
+
+      - name: Get composer cache directory
+        id: composercache
+        shell: bash
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Restore cached dependencies
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.composercache.outputs.dir }}
+          key: php-${{ matrix.php-version }}-composer-${{ hashFiles('**/composer.json') }}
+          restore-keys: php-${{ matrix.php-version }}-composer
+
+      - name: Install latest dependencies
+        run: composer update ${{ env.COMPOSER_FLAGS }}
+
+      - name: Run PHPStan
+        run: vendor/bin/phpstan analyse

composer.json

@@ -26,7 +26,7 @@
         }
     },
     "require-dev": {
-        "phpunit/phpunit": "9.6.5 || ^10.0",
+        "phpunit/phpunit": "^9.6.5",
         "phpstan/phpstan": "^1.0",
         "phpstan/phpstan-strict-rules": "^1.1"
     },

phpunit.xml.dist

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit backupGlobals="false"
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         backupGlobals="false"
          backupStaticAttributes="false"
          colors="true"
          convertErrorsToExceptions="true"

tests/Helpers/ErrorTest.php

@@ -19,9 +19,10 @@ public function testKnownCodes(): void
         $msg = 'something';
 
         foreach ($class->getConstants() as $code) {
-            if (!is_string($code)) {
-                throw new \UnexpectedValueException('Error constant must be string');
+            if (!is_string($code) || $code === '') {
+                throw new \UnexpectedValueException('Error constant must be a non-empty string');
             }
+
             $result = $this->error->get($code, $msg);
             self::assertStringStartsWith($code, $result);
             $expected = $code !== Error::ERR_VALIDATE ? '[something]' : $msg;

tests/Helpers/Patch/PatcherTest.php

@@ -141,7 +141,7 @@ public function testAssignToScalarFails($data, string $path): void
     /**
      * @return array<string, array<mixed>>
      */
-    public function scalarProvider(): array
+    public static function scalarProvider(): array
     {
         $prop = '/prop1';
         $offset = '/0';