check branch filter with equals()

chenz85 · chenz85 · commit 4999ffefe14b · 2018-11-03T01:08:15.000+08:00
diff --git a/src/main/java/org/jenkinsci/plugins/gogs/GogsWebHook.java b/src/main/java/org/jenkinsci/plugins/gogs/GogsWebHook.java
@@ -230,7 +230,7 @@ public void doIndex(StaplerRequest req, StaplerResponse rsp) throws IOException
 
             // filter branch, not ref not match branch filter, skip trigger.
             boolean isRefMatched = true;
-            if (branchFilter != null && branchFilter != "*" && branchFilter.length() > 0) {
+            if (branchFilter != null && !branchFilter.equals("*") && branchFilter.length() > 0) {
                 isRefMatched = ref == null || ref.length() == 0 || ref.endsWith(branchFilter);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ public void doIndex(StaplerRequest req, StaplerResponse rsp) throws IOException`
`230`	`230`
`231`	`231`	`// filter branch, not ref not match branch filter, skip trigger.`
`232`	`232`	`boolean isRefMatched = true;`
`233`		`- if (branchFilter != null && branchFilter != "*" && branchFilter.length() > 0) {`
	`233`	`+ if (branchFilter != null && !branchFilter.equals("*") && branchFilter.length() > 0) {`
`234`	`234`	`isRefMatched = ref == null \|\| ref.length() == 0 \|\| ref.endsWith(branchFilter);`
`235`	`235`	`}`
`236`	`236`