Fix #245

Author: n-rodriguez

lib/ajax-datatables-rails/orm/active_record.rb

@@ -15,7 +15,8 @@ def filter_records(records)
       def sort_records(records)
         sort_by = datatable.orders.inject([]) do |queries, order|
           column = order.column
-          queries << order.query(column.sort_query) if column
+          queries << order.query(column.sort_query) if column && column.orderable?
+          queries
         end
         records.order(sort_by.join(', '))
       end

spec/ajax-datatables-rails/orm/active_record_sort_records_spec.rb

@@ -29,6 +29,14 @@
         'ORDER BY users.username ASC, users.email DESC'
       )
     end
+
+    it 'should not sort a column which is not orderable' do
+      datatable.params[:order]['0'] = { column: '0', dir: 'asc' }
+      datatable.params[:order]['1'] = { column: '4', dir: 'desc' }
+      expect(datatable.sort_records(records).to_sql).to_not include(
+        'ORDER BY users.username ASC, users.post_id DESC'
+      )
+    end
   end
 
 end

spec/support/test_helpers.rb

@@ -60,7 +60,7 @@ def view_columns
       email:      { source: 'User.email'      },
       first_name: { source: 'User.first_name' },
       last_name:  { source: 'User.last_name'  },
-      post_id:    { source: 'User.post_id'    },
+      post_id:    { source: 'User.post_id', orderable: false },
       created_at: { source: 'User.created_at' },
     }
   end