Extract method, add tests

Author: n-rodriguez

lib/ajax-datatables-rails/datatable/column.rb

@@ -10,7 +10,7 @@ class Column
         sqlite:         'TEXT',
         sqlite3:        'TEXT',
         oracle:         'VARCHAR2(4000)',
-        oracleenhanced: 'VARCHAR2(4000)',
+        oracleenhanced: 'VARCHAR2(4000)'
       }.freeze
 
       attr_reader :datatable, :index, :options
@@ -38,21 +38,24 @@ def source
         @view_column[:source]
       end
 
-      # Add formater option to allow modification of the value
-      # before passing it to the database
-      def formater
-        @view_column[:formater]
+      def table
+        model.respond_to?(:arel_table) ? model.arel_table : model
       end
 
-      def table
-        model = source.split('.').first.constantize
-        model.arel_table rescue model
+      def model
+        source.split('.').first.constantize
       end
 
       def field
         source.split('.').last.to_sym
       end
 
+      # Add formater option to allow modification of the value
+      # before passing it to the database
+      def formater
+        @view_column[:formater]
+      end
+
       def formated_value
         formater ? formater.call(search.value) : search.value
       end

spec/ajax-datatables-rails/datatable/column_spec.rb

@@ -29,6 +29,44 @@
       expect(column.data).to eq('username')
     end
 
+    describe 'data' do
+      it 'should return the data from params' do
+        expect(column.data).to eq 'username'
+      end
+    end
+
+    describe 'source' do
+      it 'should return the data source from view_column' do
+        expect(column.source).to eq 'User.username'
+      end
+    end
+
+    describe 'table' do
+      context 'with ActiveRecord ORM' do
+        it 'should return the corresponding AR table' do
+          expect(column.table).to eq User.arel_table
+        end
+      end
+      context 'with other ORM' do
+        it 'should return the corresponding model' do
+          expect(User).to receive(:respond_to?).with(:arel_table).and_return(false)
+          expect(column.table).to eq User
+        end
+      end
+    end
+
+    describe 'model' do
+      it 'should return the corresponding AR model' do
+        expect(column.model).to eq User
+      end
+    end
+
+    describe 'field' do
+      it 'should return the corresponding field in DB' do
+        expect(column.field).to eq :username
+      end
+    end
+
     describe '#search' do
       it 'child class' do
         expect(column.search).to be_a(AjaxDatatablesRails::Datatable::SimpleSearch)